Skip to content

Improve stability of test_update_bucket_history_retention - #243

Merged
DemetrisChr merged 1 commit into
couchbase:mainfrom
DemetrisChr:test_update_bucket_history_retention-consistency
Aug 26, 2026
Merged

Improve stability of test_update_bucket_history_retention#243
DemetrisChr merged 1 commit into
couchbase:mainfrom
DemetrisChr:test_update_bucket_history_retention-consistency

Conversation

@DemetrisChr

Copy link
Copy Markdown
Contributor

Change

Wait until the history changes are propagated to all nodes between the update_bucket and get_bucket calls.

@DemetrisChr
DemetrisChr requested review from avsej and a lite review from Copilot August 26, 2026 11:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce flakiness in test_update_bucket_history_retention by adding a consistency wait so bucket history-retention updates are observed across the cluster before assertions run.

Changes:

  • Add a new ConsistencyHelper#wait_until_bucket_satisfies_predicate helper for bucket-level propagation checks across all management nodes.
  • Update test_update_bucket_history_retention to wait until the bucket’s history retention setting is observed before calling get_bucket.
  • Switch management host discovery in ConsistencyHelper#fetch_hosts from configuredHostname to hostname.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
test/utils/consistency_helper.rb Adjusts management host discovery and adds a new bucket-level predicate wait helper used by tests.
test/bucket_manager_test.rb Adds a propagation wait between update_bucket and get_bucket for the history-retention test.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread test/utils/consistency_helper.rb
Comment thread test/utils/consistency_helper.rb Outdated
@DemetrisChr
DemetrisChr force-pushed the test_update_bucket_history_retention-consistency branch from 606b59f to f5022e6 Compare August 26, 2026 12:34
@DemetrisChr
DemetrisChr merged commit 806b73d into couchbase:main Aug 26, 2026
38 of 44 checks passed
@DemetrisChr
DemetrisChr deleted the test_update_bucket_history_retention-consistency branch August 26, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants