Improve stability of test_update_bucket_history_retention - #243
Merged
DemetrisChr merged 1 commit intoAug 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in test_update_bucket_history_retention by adding a consistency wait so bucket history-retention updates are observed across the cluster before assertions run.
Changes:
- Add a new
ConsistencyHelper#wait_until_bucket_satisfies_predicatehelper for bucket-level propagation checks across all management nodes. - Update
test_update_bucket_history_retentionto wait until the bucket’s history retention setting is observed before callingget_bucket. - Switch management host discovery in
ConsistencyHelper#fetch_hostsfromconfiguredHostnametohostname.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/utils/consistency_helper.rb | Adjusts management host discovery and adds a new bucket-level predicate wait helper used by tests. |
| test/bucket_manager_test.rb | Adds a propagation wait between update_bucket and get_bucket for the history-retention test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DemetrisChr
force-pushed
the
test_update_bucket_history_retention-consistency
branch
from
August 26, 2026 12:34
606b59f to
f5022e6
Compare
avsej
approved these changes
Aug 26, 2026
DemetrisChr
deleted the
test_update_bucket_history_retention-consistency
branch
August 26, 2026 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Wait until the history changes are propagated to all nodes between the
update_bucketandget_bucketcalls.