-
Notifications
You must be signed in to change notification settings - Fork 13
PCBC-1074: Replica Read from Specific Replica #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Matt-Woz
wants to merge
1
commit into
couchbase:main
Choose a base branch
from
Matt-Woz:PCBC-1074
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
Couchbase/Exception/DocumentNotFoundOnReplicaException.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Copyright 2014-Present Couchbase, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Couchbase\Exception; | ||
|
|
||
| /** | ||
| * Indicates that Collection::getReplica() reached the requested replica, but it does not hold the document. | ||
| */ | ||
| class DocumentNotFoundOnReplicaException extends DocumentNotFoundException | ||
| { | ||
| } |
30 changes: 30 additions & 0 deletions
30
Couchbase/Exception/ReplicaIndexCurrentlyUnavailableException.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Copyright 2014-Present Couchbase, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Couchbase\Exception; | ||
|
|
||
| /** | ||
| * Indicates that Collection::getReplica() was asked for a replica index the bucket has, but that | ||
| * replica cannot be read right now. A rebalance resolves this; @see GetReplicaStrategy::wrap() to | ||
| * read a different replica instead. | ||
| */ | ||
| class ReplicaIndexCurrentlyUnavailableException extends CouchbaseException | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Copyright 2014-Present Couchbase, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Couchbase\Exception; | ||
|
|
||
| /** | ||
| * Indicates that Collection::getReplica() was asked for a replica index the bucket does not have: | ||
| * the index is at or beyond the bucket's configured replica count, or that count is zero. | ||
| */ | ||
| class ReplicaIndexOutOfBoundsException extends CouchbaseException | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Copyright 2014-Present Couchbase, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Couchbase; | ||
|
|
||
| class GetReplicaOptions | ||
| { | ||
| private Transcoder $transcoder; | ||
| private ?int $timeoutMilliseconds = null; | ||
| private ?RequestSpan $parentSpan = null; | ||
|
|
||
| public function __construct() | ||
| { | ||
| $this->transcoder = JsonTranscoder::getInstance(); | ||
| } | ||
|
|
||
| /** | ||
| * Static helper to keep code more readable | ||
| * | ||
| * @return GetReplicaOptions | ||
| */ | ||
| public static function build(): GetReplicaOptions | ||
| { | ||
| return new GetReplicaOptions(); | ||
| } | ||
|
|
||
| /** | ||
| * Sets the operation timeout in milliseconds. | ||
| * | ||
| * @param int $milliseconds the operation timeout to apply | ||
| * | ||
| * @return GetReplicaOptions | ||
| */ | ||
| public function timeout(int $milliseconds): GetReplicaOptions | ||
| { | ||
| $this->timeoutMilliseconds = $milliseconds; | ||
| return $this; | ||
| } | ||
|
|
||
| /** | ||
| * Associate custom transcoder with the request. | ||
| * | ||
| * @param Transcoder $transcoder | ||
| * | ||
| * @return GetReplicaOptions | ||
| */ | ||
| public function transcoder(Transcoder $transcoder): GetReplicaOptions | ||
| { | ||
| $this->transcoder = $transcoder; | ||
| return $this; | ||
| } | ||
|
|
||
| /** | ||
| * Sets the parent span. | ||
| * | ||
| * @param RequestSpan $parentSpan the parent span | ||
| * | ||
| * @return GetReplicaOptions | ||
| */ | ||
| public function parentSpan(RequestSpan $parentSpan): GetReplicaOptions | ||
| { | ||
| $this->parentSpan = $parentSpan; | ||
| return $this; | ||
| } | ||
|
|
||
| /** | ||
| * @internal | ||
| */ | ||
| public static function getParentSpan(?GetReplicaOptions $options): ?RequestSpan | ||
| { | ||
| return $options?->parentSpan; | ||
| } | ||
|
|
||
| /** | ||
| * Returns associated transcoder. | ||
| * | ||
| * @param GetReplicaOptions|null $options | ||
| * | ||
| * @return Transcoder | ||
| */ | ||
| public static function getTranscoder(?GetReplicaOptions $options): Transcoder | ||
| { | ||
| if ($options == null) { | ||
| return JsonTranscoder::getInstance(); | ||
| } | ||
| return $options->transcoder; | ||
| } | ||
|
|
||
| /** | ||
| * @param GetReplicaOptions|null $options | ||
| * | ||
| * @return array | ||
| * @internal | ||
| */ | ||
| public static function export(?GetReplicaOptions $options): array | ||
| { | ||
| if ($options == null) { | ||
| return []; | ||
| } | ||
| return [ | ||
| 'timeoutMilliseconds' => $options->timeoutMilliseconds, | ||
| ]; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Copyright 2014-Present Couchbase, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Couchbase; | ||
|
|
||
| /** | ||
| * Selects the replica that Collection::getReplica() reads from. | ||
| * | ||
| * @see Collection::getReplica() | ||
| */ | ||
| class GetReplicaStrategy | ||
| { | ||
| private int $replicaIndex; | ||
| private bool $wrap = false; | ||
|
|
||
| private function __construct(int $replicaIndex) | ||
| { | ||
| $this->replicaIndex = $replicaIndex; | ||
| } | ||
|
|
||
| /** | ||
| * Read from the replica at the given index. | ||
| * | ||
| * @param int $replicaIndex the replica to read from | ||
| * | ||
| * @see ReplicaIndex | ||
| * | ||
| * @return GetReplicaStrategy | ||
| */ | ||
| public static function fromIndex(int $replicaIndex): GetReplicaStrategy | ||
| { | ||
| return new GetReplicaStrategy($replicaIndex); | ||
| } | ||
|
|
||
| /** | ||
| * Resolve an index that cannot be read as requested to the next one that can, instead of | ||
| * failing with ReplicaIndexOutOfBoundsException or ReplicaIndexCurrentlyUnavailableException. | ||
| * | ||
| * The search walks the bucket's configured replica count, starting at the requested index | ||
| * modulo that count. Two failures remain: a bucket configured for no replicas still throws | ||
| * ReplicaIndexOutOfBoundsException, and a full lap that finds nothing readable throws | ||
| * ReplicaIndexCurrentlyUnavailableException. | ||
| * | ||
| * @param bool $wrap whether to wrap around the available replicas | ||
| * | ||
| * @return GetReplicaStrategy | ||
| */ | ||
| public function wrap(bool $wrap): GetReplicaStrategy | ||
| { | ||
| $this->wrap = $wrap; | ||
| return $this; | ||
|
Matt-Woz marked this conversation as resolved.
|
||
| } | ||
|
|
||
| /** | ||
| * @param GetReplicaStrategy $strategy | ||
| * | ||
| * @return array | ||
| * @internal | ||
| */ | ||
| public static function export(GetReplicaStrategy $strategy): array | ||
| { | ||
| return [ | ||
| 'replicaIndex' => $strategy->replicaIndex, | ||
| 'wrap' => $strategy->wrap, | ||
| ]; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.