fix: normalize route paths with a leading slash#591
Open
firas-yangui wants to merge 5 commits into
Open
Conversation
5f9f82e to
1c14d8d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Hey, thanks for the contribution! I will have a look at the code soon, but in the meantime please note that #593 already fixes the Miri problems, so you don't have to worry too much about them. |
Author
|
@m4tx Thanks for the heads-up and for taking the time to review my contribution! I’ll remove the Miri-related change so this PR stays focused on the routing issue. Looking forward to your feedback. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue or discussion
Fixes #589
Description
Normalize non-empty route patterns in
PathMatcher::newby prepending a leading slash when one is omitted.This keeps request matching, URL reversing, and
Route::url()consistent while preserving the existing behavior for empty path patterns.Type of change
Testing
cargo test -p cot --all-featurescargo test -p cot --all-features router:: --libcargo clippy -p cot --lib --all-features -- -D warningscargo fmt --all -- --checkThe repository's full all-targets Clippy command currently reports two pre-existing
assertions_on_constantserrors incot/src/db/fields/chrono_fields.rs.Checklist
just test-all)just clippy)cargo fmt)