Stream crystal hits to "UC" instead of "UH" in ROA output#156
Open
fhagemann wants to merge 1 commit into
Open
Conversation
Collaborator
|
Let me think about this - the roa / UH format is the universal format to get stuff into melinator. |
Collaborator
|
The dat format was originally intended to just store all the information which was in the class. |
Collaborator
|
we just stopped updating it at some point in time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when running simulations with the EM massmodels, the current implementation of the DEE results in

MStripHitsandMCrystalHitsboth being saved toUHto the ROA file. This messes up parsing these ROA files, because the rows for crystal hits have fewer entries:I was wondering whether
UHhere is actually correct, or whether it should be exclusively reserved forMStripHits.It looks like
MShieldCrystalHitsfor example are saved toUCinstead ofUH:nuclearizer/src/MShieldCrystalHit.cxx
Lines 159 to 163 in 79ac091
whereas
MCrystalHitsare saved toUH:nuclearizer/src/MCrystalHit.cxx
Lines 159 to 163 in 79ac091
Writing
MCrystalHitsalso toUCinstead ofUHwould prevent my current scripts from failing in case ACS hits are present in the simulations 😇