chore(deps): resolve high brace-expansion findings - #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vscode/test-clifrom 0.0.12 to 0.0.15 before changing transitive resolutions@vscode/test-electron, from 2.5.2 to 3.1.0; test-cli 0.0.15 develops against the v3 runtime, which supports VS Code 1.131's renamed platform executablesbrace-expansionoverrides to cover the new vulnerable ranges from GHSA-mh99-v99m-4gvg / CVE-2026-14257npm-run-allpaths to patched releases without upgrading unrelated direct dependenciesLockfile review
The
@vscode/test-cliupdate refreshes its declared toolchain family, includingc810.1.3 → 11.0.0,chokidar3.6.0 → 5.0.0,enhanced-resolve5.20.1 → 5.24.5,mocha11.7.5 → 11.7.6, and their associatedminimatch/yargsdependencies. Obsolete chokidar v3 support packages are removed.The
@vscode/test-electronupdate changes only that package and its sharedsemverresolution. It fixes the VS Code 1.131 launch path (Contents/MacOS/Coderather than the legacyContents/MacOS/Electron) and matches the Node 22 floor already used by the repository and CI.The vulnerable paths now resolve as follows:
@vscode/test-cli > mocha > minimatch > brace-expansion: 2.1.2 → 2.1.4npm-run-all > minimatch > brace-expansion: 1.1.16 → 1.1.18No unrelated direct dependency upgrades were included.
Verification
pnpm install --frozen-lockfilepnpm audit --json— 0 vulnerabilitiespnpm why brace-expansion— all paths resolve to patched 1.1.18, 2.1.4, 5.0.8, or 5.0.9pnpm test— 26 passing against VS Code 1.131.0pnpm run packagepnpm run verify:releasepnpm run watchsmoke test — both esbuild and TypeScript watchers started; TypeScript reported 0 errors