WIP: merge train verification (153 + fd-hygiene + migration + latency-shield)#155
Merged
Conversation
Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
…failures Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
The PATH-enrichment change routed unix LSP spawns through effective_path::new_command and dropped the std::process::Command import, breaking the cfg(windows) cmd.exe branch. Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
The revival ownership layer predates the reconfigure() interface method added by the LSP fresh-install fix; forward it to the active pool so post-install LSP path refreshes survive a revival. Biome autofix over the merged train files. Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
Impoverishment detection now checks only the core tool dirs (homebrew, /usr/local/bin, cargo, ~/.local/bin). The interactive-gated extras (bun, pnpm, mise, deno, volta) are appended to every constructed PATH anyway, so their absence alone must not trigger a login-shell probe — and on developer machines where they exist on disk, the old combined list made every rich PATH read as impoverished. Fixes the two CI test failures on real runner filesystems. Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
- effective_path::new_command splits into unix/non-unix variants so the Windows build has no unused-mut under -D warnings - bind-blocker snapshot test retries the try-lock briefly instead of demanding the first attempt wins the scheduler-lock race - legacy-preservation assertion compares SQLite data files only: any read-only connection open rewrites -wal/-shm sidecars by design, which Linux runners surfaced deterministically Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
… PATH test seam - crash/retry mid-migration mechanics drive migrate_legacy_with_lease synchronously (thread-local failure seams apply on the calling thread); the background integration path is covered by the convergence test - old-binary drift test polls with the runtime drain, matching how background migration results install in production - AFT_TEST_RAW_PATH seam: test-spawned aft processes keep their exact constructed PATH (login-shell probe + standard-dir enrichment would re-add real tool dirs and break missing-binary simulations) Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
The AFT_TEST_RAW_PATH isolation seam (added so formatter/checker tests can construct exact impoverished PATHs) defaults ON for every harness spawn, which silently disabled the probe+enrichment pipeline inside the one test that exists to verify it. The seam now treats "0"/empty as unset and the PATH test opts back in. Co-authored-by: Alfonso <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI-as-gate: local box has a machine-level exec wedge (fresh binaries SIGKILL/hang on spawn — syspolicyd/AMFI, needs reboot). This draft PR exists to run the full test matrix on the merge train while local verification is impossible. Will be closed, never merged as a PR (train lands via fast-forward push to main).
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Summary by cubic
Refreshes LSP paths after auto-install without restarting bridges and adds a TypeScript doctor warning. Also bounds idle project artifacts, shields configure from heavy-init saturation, refines PATH detection to avoid unnecessary login-shell probes, and restores Windows LSP spawns; adapts migration tests for background-lane behavior and improves CI stability.
New Features
@cortexkit/aft-bridge: addBridgePool.reconfigure(projectRoot, overrides)and apply updatedlsp_paths_extrato live bridges after npm/GitHub installs; future spawns inherit via pool overrides.RevivableTransportPoolnow forwardsreconfigureso post-install path refresh survives revival.@cortexkit/aft-clidoctor: warns when the TypeScript server is running but the project cannot resolve thetypescriptpackage.Refactors and Fixes
subc: evict idle per-project caches and stop watcher runtimes after 30 minutes; reopen lazily and reattach watchers on first request.@cortexkit/aft-bridge: exportstripHarnessSpecificConfigKeys,OPENCODE_ONLY_KEYS, andPI_ONLY_KEYS;opencode-pluginandpi-pluginstrip the other harness’s top-level keys before strict validation; unknown keys still fail.effective_path::new_command, stabilize login-shell PATH probing (incl. fish), and refine impoverishment detection to only core tool dirs; use it for git, formatters, and spawned tools to avoid transient PATH failures.std::process::Commandimport for batch-file spawn path to fix LSP startup on Windows.effective_path::new_commandinto unix/non-unix for Windows warnings; relax bind-blocker snapshot test; compare only SQLite data files; adapt adversarial migration tests to background-lane migration; addAFT_TEST_RAW_PATHto keep test PATH raw for missing-binary simulations; PATH-feature test opts out of this seam (AFT_TEST_RAW_PATH=0or empty disables it).Written for commit 4025daa. Summary will update on new commits.