Repository navigation
fix: prevent stale deleted elements from causing lost items in concurrent GetOrInsert - #83
Open
AdamMagued wants to merge 2 commits into
Open
AdamMagued wants to merge 2 commits into
AdamMagued wants to merge 2 commits into
Conversation
…rent GetOrInsert Under concurrent GetOrInsert operations, an item could be inserted adjacent to a concurrently deleted element or a deleted element could be matched during list search, leading to elements being omitted during Range traversal and counter discrepancies. Add validation for deleted flags during list traversal, element search, and CAS insertion. Add concurrent regression test TestGetOrInsertConcurrentIssue81. Fixes cornelk#81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under concurrent GetOrInsert operations, an item could be inserted adjacent to a concurrently deleted element or a deleted element could be matched during list search, leading to elements being omitted during Range traversal and counter discrepancies.
Add validation for deleted flags during list traversal, element search, and CAS insertion to ensure concurrent mutations properly retry. Add concurrent regression test TestGetOrInsertConcurrentIssue81.
Fixes #81