Repository navigation
perf(query): optimize temporal filter evaluation and literal decoding (#636) - #641
Merged
Merged
Conversation
…#636) - Replace reflective CoreseDatatype instantiation with fast constructBuiltin switch - Add fast epochMillis comparison in CoreseDate/CoreseDateTime for equal-timezone operands - Introduce lazy cached dateTime/date decoding on CoreseStringableImpl - Use singleton DatatypeFactory in SimpleDate and SimpleDateTime - Add identity short-circuit for xsd:dateTime cast on already-typed terms - Clean up unused fields and resolve S1301 switch alerts
|
Test Results 416 files 416 suites 26s ⏱️ Results for commit 8879895. |
… exception handling - Address Copilot review feedback: - Guard CoreseDate.cast(RDF.xsddate) to verify getCode() == DATE before returning this, preventing CoreseDateTime masquerade - Widen catch in CoreseDatatype.createDatatype to catch RuntimeException matching legacy reflection behavior - Refactor epoch calculation into computeSafeEpoch helper handling specific exceptions - Add testCastIdentityAndConversions unit test
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #636
Summary of Changes
Class.forNameandConstructor.newInstancewith directconstructBuiltinswitch for standard XSD datatypes.epochMilliswith fast primitiveXMLGregorianCalendar.compare().cachedDateTimeandcachedDate) with sentinel, eliminating duplicate parsing across join intermediate tuples. Refactoredcast()reducing Cognitive Complexity to < 10.DATATYPE_FACTORYeliminating per-instance allocation overhead.XSDDatatype.DATETIMEterms.Benchmarks & Validation