fix: FPs with lastLogin keyword - #52
Closed
azurit wants to merge 8 commits into
Closed
Conversation
This test is disabled due to unsupported plugin configuration changes.
EsadCetiner
reviewed
Jul 18, 2026
EsadCetiner
left a comment
EsadCetiner
left a comment
Member
There was a problem hiding this comment.
Based on the tests, couldn't this false positive be fixed by adding @ to lastlogin?
Member
Author
@EsadCetiner Yes, probably, but I don't think the |
Member
|
@azurit The command based unix rules are generally known to be a bit noisy, so I think it's worth it to fight even the less-common false positives. I can still merge this PR though as it'll fix the false positive for LTS users. |
Member
|
Related to: coreruleset/coreruleset#4593 |
Member
Author
|
Resolved by coreruleset/coreruleset#4593. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.