Repository navigation
test: cover protocol constants and version - #111
Merged
Merged
Conversation
miabbott
force-pushed
the
test/theedge-4595-protocol
branch
from
September 18, 2026 16:25
01cdeff to
912d36e
Compare
runcom
approved these changes
Oct 15, 2026
mcattamoredhat
approved these changes
Oct 16, 2026
mcattamoredhat
left a comment
mcattamoredhat
left a comment
There was a problem hiding this comment.
LGTM. No actionable defects found.
knecasov
reviewed
Oct 20, 2026
miabbott
force-pushed
the
test/theedge-4595-protocol
branch
from
October 20, 2026 14:25
912d36e to
02ed61c
Compare
Contributor
Author
|
The latest CI run fails only during linting on macOS, Windows, Fedora ARM, and the Makefile job. Builds and tests pass. The failure is:
CI currently pins I created a change in #114 that should probably merge first. |
miabbott
force-pushed
the
test/theedge-4595-protocol
branch
2 times, most recently
from
October 20, 2026 15:22
a0a0c3e to
b6d4ccb
Compare
Assisted-by: AI Signed-off-by: Micah Abbott <miabbott@redhat.com>
Replace the impossible empty fallback with a direct leading slash strip. filepath.Join always supplies the leading slash. Assisted-by: AI Signed-off-by: Micah Abbott <miabbott@redhat.com>
miabbott
force-pushed
the
test/theedge-4595-protocol
branch
from
October 20, 2026 15:30
b6d4ccb to
7fc64e8
Compare
djach7
approved these changes
Oct 20, 2026
runcom
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.