Skip to content

fix(node): install libatomic1 in the prepare step - #8074

Merged
viceice merged 2 commits into
mainfrom
viceice/fix/node-libatomic
Oct 29, 2026
Merged

viceice merged 2 commits into
mainfrom
viceice/fix/node-libatomic

Conversation

@viceice

@viceice viceice commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Changes

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Claude Code (Claude Opus 5.5) found the cause, wrote the fix and the test changes.

Use of AI in replying to PR comments

Who answers review comments:

  • @viceice will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • An agent will draft replies and reply autonomously. This is heavily discouraged, and we prefer that there are humans in the loop
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Node environment preparation now installs a required system support package before completing setup, improving compatibility in Debian-based environments.
    • Package installation uses a noninteractive mode, helping setup complete without waiting for user input.

viceice and others added 2 commits October 29, 2026 08:45
Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

Node preparation now installs libatomic1 before initialization and symlink setup. The VP test Docker stages define Node version 24.22.1 for setup downloads.

Changes: Node preparation

Layer / File(s) Summary
Install libatomic1
src/cli/tools/node/index.ts, src/cli/tools/node/index.spec.ts
NodePrepareService uses AptService to install libatomic1. The test clears APT_HTTP_PROXY and checks the apt-get call and noninteractive Debian frontend environment.

VP setup Node version

Layer / File(s) Summary
Pin VP setup Node version
test/node/Dockerfile, test/node/Dockerfile.arm64
Both test-vp stages define VP_SETUP_NODE_VERSION=24.22.1 and include Renovate metadata for updates.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Low · up to c0445

VP test setup can drift to a different Node LTS than intended; apply the pin at the actual installer boundary.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@viceice
viceice merged commit ff652d5 into main Oct 29, 2026
40 of 41 checks passed
@viceice
viceice deleted the viceice/fix/node-libatomic branch October 29, 2026 07:49
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 14.56.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant