You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Grace Cathedral got three more lasers (25 → 28). New preset grace-28 keeps the two rings of twelve exactly as in grace-cathedral (indices 1–24 unchanged, so venue numbering and BEYOND mapping still hold) and replaces the centre dot with a ring of four at radius 0.25 (indices 25–28, a diamond at 12/3/6/9 o'clock).
grace-cathedral is left untouched. Also added a "Grace 28" layout filter in the animation catalog and listed the preset in the CLI README. Test checks count, that fixtures 0–23 sit at the same positions as grace-cathedral, and that the four centre fixtures are ring 0 at radius 0.25.
📍 Findings outside the diff (1) — 🟠 1 high — defects on lines GitHub can't attach comments to
🟠 High — Catalog test omits new grace-28 filter
This PR adds the grace-28 entry to layoutFilters() (packages/animations/src/catalog.ts:161), but packages/server/__tests__/catalog.test.ts still asserts the old four-element id list, so the toEqual check fails once the change lands. The adjacent consumer touch-points were updated consistently, but this server catalog test was missed; the failure blocks CI.
This PR introduces a grace-28 layout preset built on ringsLayout, combining a 12-cannon outer ring, a 12-cannon mid ring (positions 1-24 preserved from grace-cathedral), and a 4-cannon centre ring at radius 0.25. The preset is registered in presets.ts, exposed via layoutFilters() in catalog.ts:161, documented in the CLI README, and covered by a new layout config unit test.
The catalogue and consumers were updated consistently, but one consumer, the server catalog test, was missed: adding the new filter makes layoutFilters() return five ids while packages/server/__tests__/catalog.test.ts:54 still asserts the old four-element list, so the toEqual assertion fails and blocks CI.
Files
Change
packages/layout/src/presets.ts
Adds the grace-28 rings layout preset definition
packages/animations/src/catalog.ts
Registers the grace-28 entry in layoutFilters()
packages/layout/__tests__/config.test.ts
Adds a unit test validating the grace-28 resolve and fixture indexing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Grace Cathedral got three more lasers (25 → 28). New preset
grace-28keeps the two rings of twelve exactly as ingrace-cathedral(indices 1–24 unchanged, so venue numbering and BEYOND mapping still hold) and replaces the centre dot with a ring of four at radius 0.25 (indices 25–28, a diamond at 12/3/6/9 o'clock).grace-cathedralis left untouched. Also added a "Grace 28" layout filter in the animation catalog and listed the preset in the CLI README. Test checks count, that fixtures 0–23 sit at the same positions asgrace-cathedral, and that the four centre fixtures are ring 0 at radius 0.25.Link to Devin session: https://app.devin.ai/sessions/c4872c2982734093bdee80d04a7d5ceb
Open in Devin Desktop: https://app.devin.ai/desktop/session/c4872c2982734093bdee80d04a7d5ceb?variant=devin
Requested by: @pyramation