fix(inquirerer): apply inactivity timeout to all environments, not just non-TTY#91
Merged
Conversation
…st non-TTY The timeout was gated behind `!input.isTTY`, so it only fired in non-TTY environments (CI, pipes). This meant running a CLI command from a real terminal without required arguments would show an interactive prompt instead of timing out with usage info. Remove the isTTY guard so the timeout applies universally. The reset-on-keypress design already protects interactive users — the timer resets on every keystroke, so it only fires when nobody is typing.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
PromptTimeoutErrorinactivity timeout (added in #90) was gated behind!(input as any).isTTY, so it only fired in non-TTY environments (CI, pipes). Running a CLI from a real terminal without required arguments would show an interactive prompt and hang forever instead of timing out with usage info.The reset-on-keypress design (
setupInputActivityListener/resetInactivityTimeout) already handles active interactive users — the timer resets on every keystroke, so it only fires after 15s of complete inactivity. This makes it safe to enable universally.Also updated
formatTimeoutErrormessaging to be environment-agnostic (no longer says "non-interactive environment").Link to Devin session: https://app.devin.ai/sessions/0742309126f34ef584e8dd827828d723
Requested by: @pyramation