fix(agentic): machine-protocol/runner/agent-cli publish with a real dependency version, not workspace: - #1862
Merged
Merged
Conversation
…na's workspace: rewrite reaches dist/package.json
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found. This PR fixes packaging of the three
No defects found; the dependency-specifier change is semantically safe within the workspace and required for the publish flow. Reviewed commit: b5e3651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tarballs on npm today are uninstallable:
(same for
machine-runner@0.2.0). Any consumer install fails withERR_PNPM_WORKSPACE_PKG_NOT_FOUND … while installing the dependencies of @constructive-db/agent-cli.Cause: lerna rewrites
workspace:ranges in the package-rootpackage.jsonbefore packing, but we publishdist/, anddist/package.jsonis whatever makage copied at the last build — pre-rewrite. Every other publishable package inagentic/declares"prepack": "npm run build", so the copy is regenerated after the rewrite; these three were the only ones missing it. Verified locally: withprepack, editing the range and running the build lands the edited range indist/package.json.Change:
machine-protocol,machine-runner,agent-clieach gain"prepack": "npm run build"(3 lines).After merge:
npx lerna publish(patch of all three) and the new tarballs carry"@constructive-db/machine-protocol": "^0.2.x".Link to Devin session: https://app.devin.ai/sessions/3c993d055ffb47f6be27862718a9cd42
Open in Devin Desktop: https://app.devin.ai/desktop/session/3c993d055ffb47f6be27862718a9cd42?variant=devin
Requested by: @pyramation