fix: replace workspace:^ in peerDependencies with real version ranges#1321
Merged
Conversation
graphile-llm had 'graphile-search: workspace:^' in peerDependencies which leaked into the published package on npm, breaking 'npm install -g pgpm' (EUNSUPPORTEDPROTOCOL). Same issue existed in graphile-postgis, graphile-pg-aggregates, and graphile-ltree for graphile-connection-filter. pnpm replaces workspace: protocols in dependencies during publish, but peerDependencies are not always replaced by the lerna/makage publish pipeline.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm install -g pgpmfails withEUNSUPPORTEDPROTOCOL: Unsupported URL Type "workspace:"becausegraphile-llm@0.14.0was published with"graphile-search": "workspace:^"in itspeerDependencies.The
workspace:protocol is a pnpm feature that should be replaced with real versions during publish, but the lerna/makage publish pipeline doesn't replace it inpeerDependencies— only independencies.The dependency chain:
pgpm→@pgpmjs/export→@pgpmjs/migrate-client→@constructive-io/graphql-query→graphile-settings→graphile-llm@0.14.0(boom).Fix: replace
workspace:^with real version ranges inpeerDependenciesacross 4 packages:Only
graphile-llmis currently broken on npm; the other three are preventive fixes (same pattern, not yet leaked to published versions).Link to Devin session: https://app.devin.ai/sessions/8405d6fc90a04e5e9e17471f7eb69e33
Requested by: @pyramation