Skip to content

fix(fullsend): match GitHub App author logins - #281

Merged
Acepresso merged 1 commit into
conforma:mainfrom
Acepresso:ec-2404-skip-dependency-bot-reviews
Nov 18, 2026
Merged

Acepresso merged 1 commit into
conforma:mainfrom
Acepresso:ec-2404-skip-dependency-bot-reviews

Conversation

@Acepresso

Copy link
Copy Markdown
Contributor

Use app/renovate and app/red-hat-konflux in REVIEW_SKIP_AUTHORS to match the author.login values returned for these PRs.

ref: https://redhat.atlassian.net/browse/EC-2432
assisted-by: Codex (GPT-6)

Use app/renovate and app/red-hat-konflux in REVIEW_SKIP_AUTHORS
to match the author.login values returned for these PRs.

ref: https://redhat.atlassian.net/browse/EC-2432
assisted-by: Codex (GPT-6)
@Acepresso
Acepresso requested a review from a team as a code owner November 18, 2026 10:08
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

The review configuration updates the REVIEW_SKIP_AUTHORS values for both runner and sandbox from bot-style names to app-style identifiers.

Changes: Review author skip configuration

Layer / File(s) Summary
Update skipped author identifiers
.fullsend/customized/harness/review.yaml
Both runner and sandbox now list app/renovate and app/red-hat-konflux in REVIEW_SKIP_AUTHORS.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: st3penta, bohdanmar

Merge Risk: Minimal · up to 009de

This updates which bot authors are skipped for review so that they match the identifiers GitHub returns. No concrete defect was found, and the change is easy to revert.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(fullsend): match GitHub App author logins" matches the change. The PR changes REVIEW_SKIP_AUTHORS values for runner and sandbox from renovate[bot],red-hat-konflux[bot] to app/renovate,a…
Description check Passed The description states that REVIEW_SKIP_AUTHORS now uses app/renovate and app/red-hat-konflux to match author.login values. This matches the file change in .fullsend/customized/harness/review.yaml. It…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(fullsend): match GitHub App author logins" matches the change. The PR changes REVIEW_SKIP_AUTHORS values for runner and sandbox from renovate[bot],red-hat-konflux[bot] to app/renovate,app/red-hat-konflux so they match the author.login values GitHub returns for these app-authored PRs. The title is specific and short, and it names the main change.

Full details: Description check

Explanation

The description states that REVIEW_SKIP_AUTHORS now uses app/renovate and app/red-hat-konflux to match author.login values. This matches the file change in .fullsend/customized/harness/review.yaml. It also links the tracking issue EC-2432.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 4a8fed9f-0079-4976-8477-00c9139f378a
Commits

Reviewing files that changed from the base of the PR and between 4be298d and 009de42.

Files selected for processing: 1

  • .fullsend/customized/harness/review.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 8 remain after this review.

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Nov 18, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Single-file, 4-line config update to bot author login patterns in a review workflow YAML with no protected paths, no security-sensitive files, no dependency changes, low churn (1 commit in 30 days), and a Tier 1 composite of 1.1 combined with a Tier 2 composite of 1.3 yields a weighted score of 1.2, rounding to 1.

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: PR is a bug fix correcting REVIEW_SKIP_AUTHORS format

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJmaW5kaW5ncyI6W119 -->

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge bug Something isn't working labels Nov 18, 2026
@Acepresso
Acepresso merged commit b01aa6f into conforma:main Nov 18, 2026
75 checks passed
@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #281 — fix REVIEW_SKIP_AUTHORS format for GitHub App logins

PR #281 is a follow-up fix to PR #280. PR #280 (merged Nov 17) added REVIEW_SKIP_AUTHORS: "renovate[bot],red-hat-konflux[bot]" — but renovate[bot] is the REST/UI display name, while the harness runner's skip check in pre-review.sh compares against the value returned by gh pr view --json author, which uses the GraphQL format app/renovate. The mismatch meant bot PRs were never skipped. Within hours of merging PR #280, two renovate PR review runs (44089058924, 44089043541) ran full reviews on bot PRs, then triggered fix-stage routing that failed with exit code 1 (44091615926, 44090949330). PR #281 corrected the format to app/renovate,app/red-hat-konflux and was merged Nov 18.

Review quality gap: The review agent approved PR #280 without catching that renovate[bot] does not match the runtime format. On PR #281, the correctness sub-agent explicitly noted that app/<name> matches the GitHub API format — but it missed the inverse on PR #280. The retro agent on PR #280 also called it "clean, well-executed" without detecting the format issue.

Cost of the miss: Two PRs for a 2-line config change, two rounds of human review (6 human approvals total), one unnecessary retro run, two failed workflow runs on bot PRs, and wasted review-agent tokens on bot PRs that should have been skipped.

Judge scores:

# Score Candidate Disposition
1 4/5 pre-review.sh should normalize [bot] and app/ login formats in REVIEW_SKIP_AUTHORS matching filed
2 2/5 Review agent missed incorrect format in PR #280 summary-only — isolated review gap, better addressed by normalizing the matching logic
3 1/5 Retro agent on PR #280 missed the format bug summary-only — retro agent evaluates workflow process, not content correctness
4 3/5 Fix eligibility check exits non-zero when correctly skipping bot PRs summary-only — duplicate of fullsend#7739, fullsend#8130, fullsend#8382, fullsend#8665

Evidence for existing issues:

  • fullsend#7739 / fullsend#8130 / fullsend#8382 / fullsend#8665: Runs 44091615926 and 44090949330 show the fix eligibility check correctly rejecting bot PRs but exiting with code 1, causing workflow failure conclusion.
  • fullsend#9384: That issue documents another repo (konflux-ci/renovate-log-analyzer) also using the [bot] format for REVIEW_SKIP_AUTHORS, confirming the pattern of repos using the wrong format.
  • agents#257: The original proposal (agents#368, closed) used renovate[bot] as its example format, contributing to the recurring misconfiguration.

Proposals skipped (target repo not allowed)

File manually or update create_issues.allow_targets in config.yaml:

  • Normalize bot login formats in pre-review.sh REVIEW_SKIP_AUTHORS matching (fullsend-ai/agents)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready-for-merge All reviewers approved — ready to merge risk/low PR risk: low size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants