Skip to content

chore(deps): Update ubi-minimal base image (main) - #3742

Closed
st3penta wants to merge 1 commit into
conforma:mainfrom
st3penta:ec2387-ubi-main
Closed

st3penta wants to merge 1 commit into
conforma:mainfrom
st3penta:ec2387-ubi-main

Conversation

@st3penta

Copy link
Copy Markdown
Contributor

Update ubi-minimal base image to latest digest.

Old digest: sha256:baafce2d34783a28b4a472779f304e97e00f9d35c99553bc53b068b14344d9a9
New digest: sha256:d8162789d7913ef8941481687b92ab4bbec311870948f66cf52b9cc7e0c57c06

RPM changes

- krb5-libs-1.21.1-10.el9_8.1
+ krb5-libs-1.21.1-10.el9_9.2
- rpm-4.16.1.3-40.el9
+ rpm-4.16.1.3-43.el9_9
- rpm-libs-4.16.1.3-40.el9
+ rpm-libs-4.16.1.3-43.el9_9

Ref: https://redhat.atlassian.net/browse/EC-2387
Co-Authored-By: glm-5-3 noreply@z.ai

Old digest: sha256:baafce2d34783a28b4a472779f304e97e00f9d35c99553bc53b068b14344d9a9
New digest: sha256:d8162789d7913ef8941481687b92ab4bbec311870948f66cf52b9cc7e0c57c06

RPM changes:

- krb5-libs-1.21.1-10.el9_8.1
+ krb5-libs-1.21.1-10.el9_9.2

- rpm-4.16.1.3-40.el9
+ rpm-4.16.1.3-43.el9_9

- rpm-libs-4.16.1.3-40.el9
+ rpm-libs-4.16.1.3-43.el9_9

Ref: https://redhat.atlassian.net/browse/EC-2387
Co-Authored-By: glm-5-3 <noreply@z.ai>
@st3penta
st3penta requested a review from a team as a code owner November 19, 2026 10:21
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

Three Dockerfiles update the pinned digest for the UBI 9 minimal base image. The remaining Dockerfile instructions are unchanged.

Changes: Image digest updates

Layer / File(s) Summary
Update pinned image digests
Dockerfile, Dockerfile.dist, acceptance/kubernetes/kind/acceptance.Dockerfile
The Dockerfiles use updated pinned digests for the UBI 9 minimal image. The remaining Dockerfile instructions are unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: simonbaird, acepresso, cuipinghuo

Merge Risk: Minimal · up to b033f

This routine base image digest bump carries no identified defects. The CI failure comes from PipelineRun creation being temporarily disabled and is not caused by the change. Re-run CI once that is re-enabled to confirm the build.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "chore(deps): Update ubi-minimal base image (main)" matches the changeset. The raw summary shows the UBI 9 minimal base image digest updated in Dockerfile, Dockerfile.dist, and acceptance/ku…
Description check Passed The description states the purpose of the change: updating the ubi-minimal base image to a new digest. It gives the old and new digests and lists the RPM package changes. It links a ticket (EC-2387). …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore(deps): Update ubi-minimal base image (main)" matches the changeset. The raw summary shows the UBI 9 minimal base image digest updated in Dockerfile, Dockerfile.dist, and acceptance/kubernetes/kind/acceptance.Dockerfile. The title is short, specific, and names the primary change. The "(main)" suffix is a minor noise item but does not make the title misleading.

Full details: Description check

Explanation

The description states the purpose of the change: updating the ubi-minimal base image to a new digest. It gives the old and new digests and lists the RPM package changes. It links a ticket (EC-2387). It does not follow the required template headings ("What:", "Why:", "Tickets:"). The "What" content is covered by the first sentence. The "Why" content is only implied (latest digest, RPM updates). The ticket is linked in the Ref line rather than under a Tickets heading.

Resolution

Optional: add the "#### What:", "#### Why:", and "#### Tickets:" headings from the repository template, and state the reason for the update (for example, to pick up the RPM security fixes) under "Why:".

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 9d788566-b5ea-40a9-8b05-05c9d724009f
Commits

Reviewing files that changed from the base of the PR and between d688683 and b033ff0.

Files selected for processing: 3

  • Dockerfile
  • Dockerfile.dist
  • acceptance/kubernetes/kind/acceptance.Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Nov 19, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

XS base-image bump across 3 Dockerfiles with minimal change size; score is elevated slightly above low due to protected-path detection and CI_WORKFLOW_CHANGED signals, but the routine nature of the dependency update keeps overall risk moderate.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] Dockerfile, Dockerfile.dist — This PR modifies protected governance/infrastructure files (Dockerfile, Dockerfile.dist). No linked GitHub issue provides authorization for modifying these protected paths. Human approval is required for all protected-path changes.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

<!-- fullsend:review-findings-v2:eyJ2ZXJzaW9uIjoyLCJmaW5kaW5ncyI6W119 -->

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.61% <ø> (ø)
generative 12.22% <ø> (ø)
integration 23.62% <ø> (ø)
unit 72.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Acepresso Acepresso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsmid1 jsmid1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonbaird

Copy link
Copy Markdown
Member

/retest cli-main-on-pull-request

@simonbaird

Copy link
Copy Markdown
Member

Replaced by #3748 .

@simonbaird simonbaird closed this Nov 21, 2026
@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3742 — UBI base image digest bump

Timeline

  1. 2026-11-19 10:22 — PR opened by st3penta (co-authored by glm-5-3). XS change: update ubi9/ubi-minimal pinned digest across 3 Dockerfiles (6 lines changed).
  2. 2026-11-19 10:22–10:34 — Review agent run 44504985058 completed. Three sub-agents (correctness, security, style) found zero issues. Risk assessment scored 2/5 (moderate). However, the protected-path check matched Dockerfile and Dockerfile.dist, and the agent escalated to a High finding because no linked GitHub issue was found (the PR referenced a Jira ticket EC-2387, which the agent cannot verify). Final verdict: REQUEST_CHANGES.
  3. 2026-11-19 10:46–13:30 — Three human reviewers (Acepresso, jsmid1, simonbaird) all approved, contradicting the agent's request-changes verdict.
  4. 2026-11-21 03:56 — PR closed without merge, replaced by #3748 (broader dependency update).

Workflow quality

  • Review quality: The review agent correctly identified the files as protected paths but over-escalated a routine digest bump to a blocking finding. All three sub-agents found nothing wrong. The agent spent ~12 minutes and significant tokens deliberating on whether the Jira reference counted as a linked issue, ultimately deciding it didn't.
  • Rework rate: N/A — no code or fix agents ran.
  • Human delta: All three human reviewers approved without requesting changes. The agent's REQUEST_CHANGES verdict was a false positive.
  • Agents repo: fullsend-ai/agents (discovered from run logs at commit ce2eedd097dc).

Judge scores

Score Candidate Disposition
4 Protected-path false positive on digest-only Dockerfile bumps summary-only (duplicate of existing issues)
2 Review agent should recognize Jira references as linked-issue authorization summary-only (subsumed by broader protected-path issues)
1 Review agent token cost on trivial changes summary-only (by-design behavior, low impact)

Existing issue coverage (evidence from this retro)

The protected-path false positive for routine base image bumps is extensively covered by existing issues:

  • conforma/cli #3503 — Document UBI base image bump workflow in AGENTS.md to prevent false-positive review findings. This retro provides direct evidence: PR chore(deps): Update ubi-minimal base image (main) #3742 is exactly the scenario Document UBI base image bump workflow in AGENTS.md to prevent false-positive review findings #3503 aims to prevent.
  • conforma/cli #3502 — Add AGENTS.md guidance for UBI base image bump workflow and release branch scope.
  • fullsend-ai/fullsend #2588 — Review agent: downgrade protected-path severity for bot-authored dependency update PRs. This retro adds evidence from a human-authored (but bot-co-authored) digest bump.
  • fullsend-ai/fullsend #3164 — Review agent should downgrade protected-path for platform bot managed-file updates.
  • fullsend-ai/fullsend #3061 (closed 2026-11-19) and #5370 (closed 2026-11-19) — Both closely related issues were closed the same day this PR was opened, suggesting active work on this problem.

No new proposals are warranted — the improvement space is well-covered by existing issues that are being actively worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/moderate PR risk: moderate size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants