Skip to content

chore(deps): Update ubi-minimal base image - #3493

Merged
simonbaird merged 1 commit into
conforma:mainfrom
st3penta:bump-ubi-minimal-main
Aug 14, 2026
Merged

chore(deps): Update ubi-minimal base image#3493
simonbaird merged 1 commit into
conforma:mainfrom
st3penta:bump-ubi-minimal-main

Conversation

@st3penta

@st3penta st3penta commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 791022e1-f043-4d4c-8eba-a46581369b1d

📥 Commits

Reviewing files that changed from the base of the PR and between 2d46c7e and e112f8d.

📒 Files selected for processing (3)
  • Dockerfile
  • Dockerfile.dist
  • acceptance/kubernetes/kind/acceptance.Dockerfile

📝 Walkthrough

Walkthrough

The pull request updates the pinned UBI minimal base image digest in the main, distribution, and Kubernetes acceptance Dockerfiles. No other Dockerfile instructions or public declarations changed.

Changes

Container base image refresh

Layer / File(s) Summary
Update pinned base image digests
Dockerfile, Dockerfile.dist, acceptance/kubernetes/kind/acceptance.Dockerfile
The Dockerfiles now reference updated pinned UBI minimal image digests.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to e112f

This change updates the pinned base image to include the libarchive security fix across the relevant build files; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: simonbaird

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description and does not provide the required What, Why, or Tickets sections. Add the What, Why, and Tickets sections, including the security-update context and any related ticket.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the UBI Minimal base image update and matches the main change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 13, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:25 AM UTC · Completed 10:34 AM UTC

Commit: 87c4a29 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review

Findings

High

  • [protected-path] Dockerfile, Dockerfile.dist — This PR modifies protected files (Dockerfile, Dockerfile.dist) which are governance/infrastructure files requiring human approval. The PR has no linked issue and no description explaining why these protected files are being changed. While the change itself is a routine ubi-minimal base image digest update (sha256:dd334afa... to sha256:7c372902...) applied consistently across all three Dockerfiles, human review and approval is required for all protected-path modifications.
    Remediation: Add a PR description explaining the rationale for the base image update, or link to an issue that authorizes the change. A human reviewer must approve changes to protected paths regardless.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run

Review

Findings

High

  • [protected-path] Dockerfile, Dockerfile.dist — These files match the Dockerfile protected path prefix, which requires human approval for all modifications. The PR does not link to an issue providing authorization for the change. While the PR description explains the rationale (security update for libarchive in the ubi-minimal base image), protected-path changes require explicit human review regardless of change type.
    Remediation: Obtain human approval for protected-path changes, or link to an authorizing issue.

Labels: PR modifies Dockerfiles and updates a base image dependency


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added docker Pull requests that update Docker code dependencies Pull requests that update a dependency file labels Aug 13, 2026
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.38% <ø> (ø)
generative 12.28% <ø> (ø)
integration 23.59% <ø> (ø)
unit 72.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simonbaird

Copy link
Copy Markdown
Member

Rebase on recently merged #3496 should get it green.

@simonbaird simonbaird left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I have a nicer automation wrapper for this in #3430 which I should have suggested that you try.

@st3penta
st3penta force-pushed the bump-ubi-minimal-main branch from e112f8d to 8ce04da Compare August 14, 2026 13:53
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 14, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:54 PM UTC · Completed 2:03 PM UTC

Commit: 87c4a29 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

@simonbaird
simonbaird merged commit 48d96db into conforma:main Aug 14, 2026
20 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 14, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 4:19 PM UTC · Completed 4:29 PM UTC

Commit: 87c4a29 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3493chore(deps): Update ubi-minimal base image

Workflow: Human author (st3penta) opened a trivial 3-line PR updating the pinned UBI9 ubi-minimal base image digest across three Dockerfiles. The review agent ran twice (both from fullsend-ai/agents@v0), posting CHANGES_REQUESTED each time for a High-severity [protected-path] finding. Human reviewer simonbaird approved and merged despite the agent's objections.

Timeline

  1. Aug 13 10:24 UTC — PR opened (commit e112f8d5). Three files changed: Dockerfile, Dockerfile.dist, acceptance/kubernetes/kind/acceptance.Dockerfile — each updating one sha256: digest in a FROM line.
  2. Aug 13 10:25–10:34First review run completes. Posts CHANGES_REQUESTED with a High [protected-path] finding.
  3. Aug 13 21:42simonbaird comments: "Rebase on recently merged Update Konflux references #3496 should get it green."
  4. Aug 13 21:44simonbaird submits APPROVED review.
  5. Aug 14 13:53st3penta force-pushes (rebase to follow simonbaird's suggestion). New commit 8ce04daf.
  6. Aug 14 13:54–14:03Second review run triggered by the force-push. Posts CHANGES_REQUESTED again with the identical [protected-path] finding — effectively overriding the human's prior approval.
  7. Aug 14 16:18simonbaird merges the PR.

Assessment

The workflow completed successfully but with unnecessary friction. The review agent's CHANGES_REQUESTED verdict on a routine digest bump by a human author added no security value — the human reviewer is the authorization the protected-path check is looking for. The second review after a content-unchanged rebase compounded the problem by overriding an existing human approval.

All improvement opportunities are already tracked in existing open issues. This PR provides additional supporting evidence:

No new proposals filed — existing issue coverage is comprehensive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file docker Pull requests that update Docker code size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants