Skip to content

CIVIPLMMSR-655: Lower default reconcile batch_size from 100 to 30 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erawat wants to merge 1 commit into from
Closed

CIVIPLMMSR-655: Lower default reconcile batch_size from 100 to 30 #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions managed/Job_PaymentAttemptReconcile.mgd.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
* Parameters:
* - processor_parameters: (required) Format: "[Stripe Connect,2],[GoCardless,6]"
* Each pair specifies [ProcessorType,ThresholdDays].
* - batch_size: Max total attempts to reconcile (default: 100)
* - batch_size: Max total attempts to reconcile (default: 30)
*
* @see api/v3/PaymentAttemptReconcile/Run.php
*/
Expand All @@ -26,7 +26,7 @@
'api_entity' => 'PaymentAttemptReconcile',
'api_action' => 'Run',
'api_version' => 3,
'parameters' => "processor_parameters=[Stripe Connect,2],[GoCardless,6]\nbatch_size=100\nmax_retry_count=3",
'parameters' => "processor_parameters=[Stripe Connect,2],[GoCardless,6]\nbatch_size=30\nmax_retry_count=3",

@gemini-code-assist gemini-code-assist Bot Jun 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

WARNING: While updating the default batch_size to 30 in the managed job parameters is correct, the underlying API PaymentAttemptReconcile.Run still defaults to 100 in both its implementation (api/v3/PaymentAttemptReconcile/Run.php line 34) and its API spec (_civicrm_api3_payment_attempt_reconcile_Run_spec line 106).

To prevent inconsistency and ensure that manual API calls or other invocations also benefit from this safer default, please update the default value in the API file as well.

'is_active' => 1,
],
],
Expand Down
Loading