Repository navigation
Add an edg builder for the open-source EDG front end - #146
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019UuPJbXuMH8A4DCDNoiBiv
This was referenced Sep 30, 2026
Member
|
CC @DarkArc |
Member
|
LGTM, getting robot second opinion |
mattgodbolt
approved these changes
Sep 30, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The builder, packaging layout, dependencies, and CI integration are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Adds an EDG builder image for producing installable open-source EDG packages.
Changes:
- Builds tagged or trunk EDG releases with GNU/default modes and supporting tools.
- Adds the required Ubuntu build environment.
- Publishes the builder image through CI.
| File | Description |
|---|---|
edg/build.sh |
Builds and packages EDG releases. |
Dockerfile.edg |
Defines the EDG build environment. |
.github/workflows/build.yml |
Adds the EDG image to CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
That is really great! Thank you so much for that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PRs: #146 (builder), compiler-explorer/infra#2393 (installables), compiler-explorer/compiler-workflows#83 (daily build), compiler-explorer/compiler-explorer#9204 (properties).
EDG's C/C++ front end is now open source at https://github.com/edgcpp/compiler. This adds an
edgbuilder image so we can build it ourselves, instead of EDG sending us tarballs.edg/build.sh <tag|trunk>builds thelinux-gcc-releasepreset plus the x86-64 runtime library, then runs EDG's ownedg-pack-cpfe-cepacker for both modes. The output is one tarball:edg-<ver>/gcc/: GNU mode, including the experimental headers so<experimental/meta>works with--set_flag reflectionedg-<ver>/default/: EDG's own headers onlyedg-<ver>/tools/: EDG'sedg-scrape-compilerandmake_predef_macro_table, which the installer runs against the backend gccA tag builds
edg-<tag>.tar.xz;trunkbuildsmainasedg-trunk-<date>.tar.xzand skips if the revision hasn't changed.Two environment settings are needed:
EDG_GCC_VER_SCRAPE, as in EDG's HACKING.md: without it their build config assumes gcc 14 and passes-Wno-error=return-mismatch, which the image's gcc 11 rejects.EDG_RUNTIME_LIB=edgrt: the packer expectslibedgrt.abut the build names itlibC.aby default. Wyatt at EDG suggested this in edg-pack-cpfe-ce expects lib/libedgrt.a but the build produces libC.a edgcpp/compiler#16.Tested locally:
docker buildthenbuild.sh 7.0andbuild.sh trunkboth produce tarballs, and a rerun of trunk with the current revision reports SKIPPED. Test-installing those tarballs, GNU mode compiles and runs a C++20 program, and a P2996 reflection test with--c++26 --set_flag reflection.🤖 Generated with Claude Code
https://claude.ai/code/session_019UuPJbXuMH8A4DCDNoiBiv