fix: remove the HTS allowance from the LOCK/UNLOCK unlock path - #2
Open
dolfje wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOCK/UNLOCK token managers granted the service a finite, non-replenishable HTS allowance and then spent it down on every withdrawal. Once exhausted,
giveTokenreverts withSPENDER_DOES_NOT_HAVE_ALLOWANCEand the custodied pool becomes unredeemable, recoverable only by an implementation upgrade.This PR removes the allowance from the unlock path entirely. The token manager now pushes its own balance instead of the service pulling it, which needs no approval at all.