docs: the Action card overstated what CI enforcement does - #37
Merged
Conversation
The "GitHub Action" card said the Action is "enforcement in CI that a contributor cannot skip". Two other places on the same page are careful about this -- the pricing note says the only way Commit Check blocks a merge is if you make it a required check, and the FAQ says to make the Action or the App a required status check -- so the card was the odd one out, and the one a reader meets first. An Action that is not a required status check runs and reports and merges anyway. The new wording keeps the contrast the card was drawing with the pre-commit hook above it, which a contributor genuinely can skip with --no-verify, and states the condition for blocking a merge: Runs in CI whether or not the hook ran. Make it a required check and a violation cannot merge, with per-rule outputs later steps can gate on. Found by CodeRabbit on #36, which merged before it could be applied there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018xYa7m3qup5wyN5MaXFgf6
✅ Deploy Preview for commit-check ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reachedNext included review available in 41 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "GitHub Action" card on the home page said the Action is "enforcement in CI that a contributor cannot skip".
Two other places on the same page are careful about exactly this:
So the card was the odd one out, and it is the one a reader meets first. An Action that is not a required status check runs, reports, and the pull request merges anyway.
The new wording keeps the contrast the card was drawing with the pre-commit hook card above it — which a contributor genuinely can skip with
--no-verify— and states the condition for blocking a merge:Found by CodeRabbit on #36, which merged before the fix could be applied there.
pytest tests/passes (10) andmkdocs build --strictis clean.🤖 Generated with Claude Code
https://claude.ai/code/session_018xYa7m3qup5wyN5MaXFgf6
Generated by Claude Code