Repository navigation
Fix the local benchmark, clean up keys from a failed init, and stale v6 paths - #22
Merged
Merged
Conversation
…v6 paths - scripts/benchmark-local.sh counted files in storage/policies, which format 5 and later never create, so it stopped under set -e. The count and its summary field are removed. - git-e2ee init deletes a key it generated in the same run when a later step fails, instead of leaving an orphaned key file. A key the user passed is never touched. - scripts/benchmark-comparison.sh snapshotted storage/objects, which format 6 renamed to packs/. - docs/benchmarks.md notes that its recorded run used the old carrier branch and attributes, and what format 6 uses instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small bugs found while doing steps 3 and 4.
scripts/benchmark-local.shstopped partway. It counted files instorage/policies, a directory that format 5 and later never create, soset -ekilled the run. The count and thepolicy_filessummary field are removed. Verified by running it on a one-commit repository: exit 0.~/.config/git-e2eeand~/.local/state/git-e2eewere not created.git-e2ee initleft an orphaned key on failure. If storage setup failed afterinitgenerated a key (for example, storage already initialized), the new key file stayed behind.initnow deletes a key it created in the same run before returning the error. A key the user passed with--keythat already existed is never touched. New testfailed_init_removes_the_key_it_created: a secondiniton the same storage fails, and exactly one key remains.scripts/benchmark-comparison.shsnapshot path. It snapshottedstorage/objects, which format 6 renamed topacks/. The oldobjects/held packs only, so the check covers the same data.bash -nonly; the script was not run end to end.docs/benchmarks.md. The recorded run'srefs/heads/git-remote-e2eeande2ee/** -deltastay as historical facts. A note after them says format 6 usesmainand* -deltaat the branch root.cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test --all-targets(141 passed).