Touch only configured timestamp fields - #341
Open
elpete wants to merge 3 commits into
Open
Conversation
elpete
force-pushed
the
feat/53-touch-timestamps
branch
from
August 24, 2026 21:19
655c0bf to
822a110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
Issue review
Recommendation: 8/10 —
touchis a useful entity-level operation, but it must not accidentally persist unrelated dirty state.Implementation
timestampFields(), defaulting to[ "modifiedDate" ], so entities can override the timestamp attributes they usetouch()restore the entity to its last clean state before assigning timestampstouch( options = {} )Regression coverage
timestampFields()controls which timestamp is touchedValidation
git diff --checkpassedUses
qb@14.0.0-beta.3and targetsnext.