Reject duplicate entity property names - #337
Open
elpete wants to merge 4 commits into
Open
Conversation
elpete
force-pushed
the
test/59-explicit-column-collision
branch
from
August 24, 2026 21:19
b5c04d2 to
eebf9d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
Issue review
Recommendation: 9/10 — preserve and test. An explicit
columnmapping must always win over an identically named physical column; otherwise an entity silently hydrates incorrect data.Reproduction and follow-up
The original reported behavior cannot be reproduced on current
nextwithqb@14.0.0-beta.3: an explicitusernametofirst_namemapping wins even though the table also has a physicalusernamecolumn.Lucee does accept two entity properties with the same name and collapses them in component metadata. Quick now detects duplicate local property declarations during its cached metadata inspection and throws
QuickDuplicateProperty, avoiding an ambiguous generated accessor and column mapping.Implementation
Validation
git diff --checkpassedUses
qb@14.0.0-beta.3and targetsnext.