fix: accept retrievable builders as subqueries - #329
Open
elpete wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes coldbox-modules/quick#226
Issue review
Recommendation: 9/10. A builder recognized by qb through its
isBuildercontract should be usable in subquery positions when it exposes an underlying qb query throughretrieveQuery(). This directly supports Quick without coupling qb to Quick types.Reasons for:
retrieveQuery()already defines the interop boundary; accepting the wrapper removes an arbitrary difference between it andasQuery().Tradeoffs:
snapshotBuilder()from a nominalQueryBuildertype to a small structural contract.cloneBuilder()validation after attempted unwrapping.Reproduction
With Quick
nextand the latest prerelease dependency (qb 14.0.0-beta.3), passinggetInstance("User").where(...).asQuery().reselect("id")to a plain qbwhereIn()reproduced the reported caster exception inQueryExecutor.snapshotBuilder(). The focused Quick bundle had 4 passes and 1 error before the fix.Implementation
retrieveQuery()before cloning/snapshotting.whereIn()call and a retrievable builder fixture.Validation
git diff --checkcompleted in both repositories