Skip to content

feat(wallet-mcp): add QHooks read and prepare plugin - #24

Draft
qhooks wants to merge 5 commits into
coinbase:mainfrom
qhooks:qhooks-wallet-mcp-plugin
Draft

qhooks wants to merge 5 commits into
coinbase:mainfrom
qhooks:qhooks-wallet-mcp-plugin

Conversation

@qhooks

@qhooks qhooks commented Nov 16, 2026 •

Copy link
Copy Markdown

Description

Add an opt-in QHooks external-MCP plugin at skills/wallet-mcp/plugins/qhooks.md. Public market and stored-QProof reads stay read-only; unsigned spot preparations are checked locally against the original tool request and Wallet MCP account before they can be mapped to send_calls for approval.

The executable helper now requires the original {tool, arguments}, explicit plan/per-transaction chain IDs and the shared unsigned integrity metadata. It pins the fee router, Permit2 and five supported pool managers; decodes the current single-hop swap; checks exact input approvals to the fee router, token/side/amount, quote-derived output minimum/slippage, trader, fee, referrer, expiry and native value; and rejects unknown selectors, extra operations and wallet-authorization fields. The SHA-256 digest is not a signature or a trusted price source, and recomputing it cannot bypass those independent constraints. Server responses without the new metadata fail closed until the matching QHooks server release.

Only the original trusted tool name selects this spot branch, so a changed server response cannot downgrade a trade to the staged contract mapper. The prior OTC/agreement approval and selected-action flow remains, with its own review/simulation requirements; this spot decoder does not claim to validate those separate ABIs. No dependent call is appended to a staged approval. Launch links, perps plans, unsupported chains and uncertain outcomes stop the EVM path. Submission still requires the currently connected wallet's chain support and per-action approval; unknown requests keep their original ID.

Five transaction chains remain Base, Ethereum, Arbitrum, BNB and Robinhood Chain. Runtime QHooks tool discovery remains authoritative; the spec does not automatically register every remote tool. Source-only plugin version 0.1.1. No signer, key, shell, direct HTTP workaround, paid API, router registry, endpoint, OAuth, or generated-distribution activation is added.

Change type

  • Harness integration or metadata
  • Skill workflow
  • Bug fix
  • Documentation
  • Breaking change (describe migration)

Validation

  • python3 -m unittest discover -s tests: 39 passed, including the executable-mapper regression wrapper.
  • node --test tests/qhooks_plan.test.mjs: 7 passed on Node26 and Node22.23.1. Tests execute the actual Markdown code: 20 supported chain/currency/direction combinations, unlimited approval plus 5 ETH attacker transfer, rehashed changes to approvals/chains/senders/swap fields/value, response downgrade attempts, missing integrity/chain, staged OTC/agreement approval and selected actions, and denied perps/launch/unknown outcomes.
  • python3 scripts/build-distributions.py dist: passed. Four generated distributions preserve current source selection; Wallet MCP/QHooks remains source-only and generated output is not committed.
  • git diff --check: passed. Signed GitHub commit bytes read back exactly and signature verified.

The referenced .claude/skills/plugin-review/ is absent from this public checkout. Its dedicated skill was not run; the canonical frontmatter/section/routing checklist was reviewed manually and the actual fenced mapper is fixture-tested. Native connector OAuth/onboarding, real wallet approval, send_calls and financial execution were not exercised. No live service calls, feedback, posts, signing or funds were used by the tests.

  • Generated portable manifest and MCP config validate against the vendored Agent Plugins schemas
  • Package paths and skill references remain inside each generated plugin root
  • Marketplace, skills, MCP, and icon paths are valid
  • Exactly one canonical skill library; generated copies are not committed
  • Claude compatibility metadata/endpoint and marketplace sources agree with the portable package
  • Tool schemas, authorization, and retry behavior reviewed
  • README and changelog updated; versions consistent
  • No unapproved disclosures or sensitive data
  • Signed commits

README/changelog and maintainer registry/tables remain unchanged under the more specific plugin-spec Contribution Scope. This update changes only the plugin document and two focused regression test files; no distribution package version changes are needed. There is no deprecated base-mcp source tree to duplicate.

Release considerations

Draft for maintainer review; this does not claim endorsement or hosted allowlisting. The matching server metadata release is required before spot preparation succeeds. The user selects QHooks, reviews each plan and approves the wallet action; no unknown outcome causes a new batch. Contract-specific OTC/agreement review and simulation remain mandatory.

Add an opt-in external MCP specification for public reads and user-approved EVM plans. Preserve ordered exact calls and the current wallet approval boundary. No signer, executor, key, paid service or product distribution is added.
@cb-heimdall

cb-heimdall commented Nov 16, 2026 •

Copy link
Copy Markdown

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Emergency override progress: 0/5
These approvals do not satisfy normal or CODEOWNER requirements because the commit identity is unverified.
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
1 if authored by an app that is not allowlisted and lacks verified human attribution 0
Sum 2

qhooks and others added 4 commits November 15, 2026 18:56
Handle unfunded OTC creation and explicit transaction-level chain IDs for agreement actions. Reject inconsistent actors, mixed chains and failed simulations. No signing or submission logic.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants