Repository navigation
Conversation
Add pinned QHooks market, stored QProof, perps, OTC and agreement read/prepare tools. No signer or executor. Include native provider tests, documentation and a patch changeset.
🟡 Heimdall Review Status
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an opt-in QHooks ActionProvider with 31 pinned actions for public reads and unsigned plans, plus separately enabled feedback. It creates no wallet, accepts no private key and cannot sign, deploy or broadcast.
Eligible spot trade/launch attribution resolves explicit referrer → configured option → existing wallet public getAddress(), lazily. Reads never inspect the wallet. The public barrel exports only the provider, factory, error and options type.
The static catalog contains all 31 reviewed public tools, including competition, agent-profile and board preparation. Titles, annotations and exact input schemas match a committed catalog fixture. Development-only pin checks reject drift or unreviewed names; remote metadata cannot add runtime tools. Token-based quotes, Studio configuration strings, QProof queue opt-in and unique profile-tool names retain their constraints.
Feedback is separately default OFF. Only trusted host configuration
allowFeedback: truepermitssend_feedbackto send free text to the QHooks team; tool arguments cannot enable it. Feedback retains write annotations and there is no trade-description steering. Board/profile/join tools prepare wallet-signable material without posting or signing.agreement_jarand held order/RFQ tools remain absent.Spot preparation independently validates the local request against every returned transaction: chain IDs, trader, token/side/amount, pinned targets and manager, exact input approval, canonical single-hop calldata, quote-derived minimum/slippage, fee/referrer/deadline and native value. Unknown selectors or extra wallet-operation fields fail closed. The router pays msg.sender; no trader ABI field is invented. The unsigned SHA-256 tuple detects alteration but does not authenticate the server or establish a market price.
Release dependency: QHooks must release the additive
qhooks.trade-plan.v1integrity metadata and per-transaction chainId before these clients can prepare spot trades. Older responses fail closed. Prepared for the signing wallet: the agent's own wallet or yours. No custody; we never hold keys.Tests
Node 22.23.1: full AgentKit tsc --noEmit, provider ESLint/Prettier and 15 native Jest tests pass.
Tests use injected fixture transports only: all 31 tools over MCP and REST, 24 tampered spot-plan variants per transport (including rehashed attacker targets, unlimited approvals and native injection), schema drift, exact large amounts, unavailable states, default-off feedback, and no automatic retries. No real feedback/post, provider, paid planner, wallet signature or transaction was used. The PR stays draft pending upstream review and the contributing guide's manual example-chatbot validation; no chatbot output or transaction receipt is claimed.
Checklist
All QHooks commits are GitHub-signed and verified.