Remove deprecated fields from CLI usage - #23
Open
alec-w wants to merge 2 commits into
Open
Conversation
sd109
reviewed
Aug 14, 2026
| --oauth-issuer-url https://$AUTHORIZATION_DOMAIN \ | ||
| --oauth-authorization-url https://$AUTHORIZATION_DOMAIN/oauth2/auth \ | ||
| --oauth-token-url https://$AUTHORIZATION_DOMAIN/oauth2/token \ | ||
| --oauth-client-id $AUTHORIZATION_CLIENT_ID \ |
Contributor
There was a problem hiding this comment.
Having AUTHORIZATION_DOMAIN as the config var seems likely to cause confusion with this change if we're automatically prefixing it with https://. Should we replace it with an OAUTH_ISSUER_URL variable instead?
We also can't assume the auth and token endpoints so should remove these flags and let them be found during discovery.
Suggested change
| --oauth-client-id $AUTHORIZATION_CLIENT_ID \ | |
| --oauth-issuer-url $OAUTH_ISSUER_URL \ | |
| --oauth-client-id $AUTHORIZATION_CLIENT_ID \ |
Same suggestion is relevant to all other diff hunks in this PR.
Contributor
Author
There was a problem hiding this comment.
Good point, I'd forgotten that Connect now exposed a URL to perform discovery through. Have changed to drop these fields so we only bother keeping the client ID (and renamed the var).
sd109
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--connect-datasource,--authorization-domainand--authorization-client-idare all deprecated, swapping to replacement flags.