Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While installing the local build on my mac,
npm run install:localcrashed due to not finding the Go's license file.The script looks for it at
$(go env GOROOT)/LICENSE, which works with the official Go distribution but with HomebrewGOROOTpoints to.../libexecand the license is actually one directory up.In the meantime a workaround was to set a symlink using
ln -s ../LICENSE "$(go env GOROOT)/LICENSE"With this change the script checks the usual location first and then looks in the parent directory if it's not there.