Repository navigation
fix: resolve dependency advisories blocking publication - #48
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish job in run 41101906029 stopped at the dependency audit before authentication or publication. Newly reported minimatch and glob advisories affect the approved beta.1 commit.
Upgrade Lerna to 10, ESLint to 10 with typescript-eslint 8, and Redocly OpenAPI Core to 2 so the dependency graph can use patched minimatch/glob APIs. Apply scoped overrides for minimatch 11.0.3, glob 14.0.3, and undici 7.30.1, and align conventional-commits-parser with Lerna's peer requirement. The refreshed lockfile has zero audit findings. Development now requires Node 22.22.2+, 24.15+, or 26; the OpenAPI differ, governance, and CLI require Node 22.12+ at runtime.
Migrate the existing lint rules to flat configuration and import-x. Import the enabled dependency-check rule through its public subpath because the full plugin still imports minimatch's removed makeRe API in an unused rule. The dependency check was verified to reject an undeclared package.
Correct both audit validators to count affected versions rather than distinct advisories; registry errors, malformed reports, muted findings, and every vulnerability still fail the job. Set the publishing registry directly so setup-node no longer creates an unresolved NODE_AUTH_TOKEN placeholder for Trusted Publishing.
Validation: frozen install,
pnpm build,pnpm lint,pnpm test(14 passed),pnpm test:e2e(361 passed, 1 skipped), andpnpm audit --json(zero findings). Both workflow YAML files and shell blocks parse; eight audit-validator cases cover clean, vulnerable, malformed, muted, and registry-error reports. Lerna's existing publish flags remain supported. GitHub CI also passed on Node 22, 24, and 26, along with the dependency audit, CodeQL, and PR title checks.Release dependency: the existing beta.1 tags still point to the previously approved commit. Rerunning that commit will retain the vulnerabilities. Publishing this fix needs separate approval of a release commit and version/tag plan; this PR does not change package versions or tags and does not publish anything.