chore(data-filter): cap backtrace frames - #580
Merged
Merged
Conversation
Dobrunia
approved these changes
Jul 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces memory/storage impact from excessively large backtraces by moving backtrace/sourceCode trimming into Grouper’s DataFilter, capping frame count and source snippet size before the event is hashed/stored.
Changes:
- Add
DataFilter.trimBacktrace()to cap backtrace frames (20), sourceCode lines per frame (21), and trim long source lines. - Remove the old
GrouperWorker.trimSourceCodeLines()preprocessing step fromworkers/grouper/src/index.ts. - Add tests covering backtrace frame/line caps and empty-backtrace normalization.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| workers/grouper/tests/data-filter.test.ts | Adds test coverage for backtrace frame/line trimming and empty backtrace normalization. |
| workers/grouper/src/index.ts | Removes the worker-level backtrace/sourceCode trimming step now handled by DataFilter. |
| workers/grouper/src/data-filter.ts | Implements capped backtrace trimming and exports related constants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+27
to
+30
| /** | ||
| * Maximum length of a single source code line | ||
| */ | ||
| const MAX_CODE_LINE_LENGTH = 140; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some projects sends bloated backtraces with 80-250 frames that took too much memory.
This PR improves Grouper's DataFilter logic to cap such backtrace frames (max 20 frames).