fix: prevent inline toolbar from closing when clicking on form controls inside it - #3017
Open
waterWang wants to merge 1 commit into
Open
fix: prevent inline toolbar from closing when clicking on form controls inside it#3017waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…ls inside it When clicking on a form control (e.g. <select> or <input>) inside the Inline Toolbar popover, the selection is lost, which triggers a selectionchange event. The selectionChanged handler was unconditionally closing the Inline Toolbar when there is no selection range, even if the user is interacting with a form control inside the toolbar. Fix: check if the active element is inside the Inline Toolbar before closing it. If the user is focused on a form control inside the toolbar, keep it open. Fixes codex-team#2985
waterWang
requested review from
TatianaFomina,
gohabereg,
ilyamore88 and
neSpecc
as code owners
August 11, 2026 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2985
When clicking on a form control (e.g. or ) inside the Inline Toolbar popover, the selection is lost, which triggers a selectionchange event. The selectionChanged handler was unconditionally closing the Inline Toolbar when there is no selection range, even if the user is interacting with a form control inside the toolbar.
Changes