Skip to content

Fix: heading structure in admin screens - #437

Merged
sheabunge merged 3 commits into
core-betafrom
fix/headings/core
Aug 5, 2026
Merged

Fix: heading structure in admin screens#437
sheabunge merged 3 commits into
core-betafrom
fix/headings/core

Conversation

@ramiy

@ramiy ramiy commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@ramiy
ramiy requested review from imantsk and sheabunge August 4, 2026 10:34
@code-snippets-bot

Copy link
Copy Markdown
Contributor
  • Medium — src/css/welcome.scss:161: The changelog still renders version headings as h3 and section headings as h4, so the new h2/h3 selectors style the wrong elements: version dates lose their flex alignment and spacing, while section headings lose their intended styling. Keep the corrected h2 > h3 > h4 markup and restore these selectors to h3 and h4.

  • Low — src/css/welcome.scss:129: Article card titles are still h3 elements in WelcomeMenu.tsx, so this new h2 rule never matches and their 18px, zero-margin card styling is lost. Keep the article-card selector at h3.

  • Low — src/js/components/ImportMenu/MigrateForm/ImporterSelector.tsx:15: This heading and the two promoted upload-card headings no longer match the h3 rules in src/css/import/_migrate.scss and _upload.scss, dropping their intended card-heading spacing. Update the three scoped selectors to h2 or target semantic-independent classes.

  • Medium — src/js/components/ImportMenu/UploadForm/SelectFiles/SelectFiles.tsx:60: The conditional Import flow still skips heading levels: SelectedFilesList renders an h4 beneath this new h2, and the select/result states render top-level h4 headings directly beneath the page h1. Use h3 for the nested selected-files heading and h2 for top-level step/result headings, updating their scoped styles with them.

@ramiy

ramiy commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author
  • Medium — src/css/welcome.scss:161: The changelog still renders version headings as h3 and section headings as h4, so the new h2/h3 selectors style the wrong elements: version dates lose their flex alignment and spacing, while section headings lose their intended styling. Keep the corrected h2 > h3 > h4 markup and restore these selectors to h3 and h4.
  • Low — src/css/welcome.scss:129: Article card titles are still h3 elements in WelcomeMenu.tsx, so this new h2 rule never matches and their 18px, zero-margin card styling is lost. Keep the article-card selector at h3.
  • Low — src/js/components/ImportMenu/MigrateForm/ImporterSelector.tsx:15: This heading and the two promoted upload-card headings no longer match the h3 rules in src/css/import/_migrate.scss and _upload.scss, dropping their intended card-heading spacing. Update the three scoped selectors to h2 or target semantic-independent classes.
  • Medium — src/js/components/ImportMenu/UploadForm/SelectFiles/SelectFiles.tsx:60: The conditional Import flow still skips heading levels: SelectedFilesList renders an h4 beneath this new h2, and the select/result states render top-level h4 headings directly beneath the page h1. Use h3 for the nested selected-files heading and h2 for top-level step/result headings, updating their scoped styles with them.

Fixed.

@sheabunge

Copy link
Copy Markdown
Member

Appreciate you addressing this!

@sheabunge
sheabunge merged commit a11722f into core-beta Aug 5, 2026
9 checks passed
@sheabunge
sheabunge deleted the fix/headings/core branch August 5, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants