You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Medium — src/css/welcome.scss:161: The changelog still renders version headings as h3 and section headings as h4, so the new h2/h3 selectors style the wrong elements: version dates lose their flex alignment and spacing, while section headings lose their intended styling. Keep the corrected h2 > h3 > h4 markup and restore these selectors to h3 and h4.
Low — src/css/welcome.scss:129: Article card titles are still h3 elements in WelcomeMenu.tsx, so this new h2 rule never matches and their 18px, zero-margin card styling is lost. Keep the article-card selector at h3.
Low — src/js/components/ImportMenu/MigrateForm/ImporterSelector.tsx:15: This heading and the two promoted upload-card headings no longer match the h3 rules in src/css/import/_migrate.scss and _upload.scss, dropping their intended card-heading spacing. Update the three scoped selectors to h2 or target semantic-independent classes.
Medium — src/js/components/ImportMenu/UploadForm/SelectFiles/SelectFiles.tsx:60: The conditional Import flow still skips heading levels: SelectedFilesList renders an h4 beneath this new h2, and the select/result states render top-level h4 headings directly beneath the page h1. Use h3 for the nested selected-files heading and h2 for top-level step/result headings, updating their scoped styles with them.
Medium — src/css/welcome.scss:161: The changelog still renders version headings as h3 and section headings as h4, so the new h2/h3 selectors style the wrong elements: version dates lose their flex alignment and spacing, while section headings lose their intended styling. Keep the corrected h2 > h3 > h4 markup and restore these selectors to h3 and h4.
Low — src/css/welcome.scss:129: Article card titles are still h3 elements in WelcomeMenu.tsx, so this new h2 rule never matches and their 18px, zero-margin card styling is lost. Keep the article-card selector at h3.
Low — src/js/components/ImportMenu/MigrateForm/ImporterSelector.tsx:15: This heading and the two promoted upload-card headings no longer match the h3 rules in src/css/import/_migrate.scss and _upload.scss, dropping their intended card-heading spacing. Update the three scoped selectors to h2 or target semantic-independent classes.
Medium — src/js/components/ImportMenu/UploadForm/SelectFiles/SelectFiles.tsx:60: The conditional Import flow still skips heading levels: SelectedFilesList renders an h4 beneath this new h2, and the select/result states render top-level h4 headings directly beneath the page h1. Use h3 for the nested selected-files heading and h2 for top-level step/result headings, updating their scoped styles with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.