feat: refresh snippet table, preview and notice presentation - #422
Conversation
| inset-block-start: 18px; | ||
| inset-block-start: 35px; | ||
| inset-inline-end: 56px; | ||
| transform: translateY(-50%); |
There was a problem hiding this comment.
there should be abetter solution imo
There was a problem hiding this comment.
the absolute positioning and magic offsets are gone. The badge now renders as the first row of the modal content, aligned to the inline end under the title, plain flex flow (f740d76). Placement is covered by the geometry assertions in the preview spec.
|
|
Addressed all three findings: the loading and error notices now use live-region semantics ( |
|
|
Download state is now owned by a shared per-snippet provider rather than each button: card, table, and preview actions read the same pending/downloaded record, so a download in the preview immediately flips every sibling action and repeat downloads are prevented even before the results refresh completes or if it fails. Covered by e2e cases for the delayed-refresh and failed-refresh paths. Verified with lint, PHPUnit (single and multisite), the build, and the featured + preview Playwright suites. |
Download and install |
Summary
Community Cloud
Preview modal
Snippet tables
Admin chrome
Tests
Compatibility
Verification
npx eslint src testsnpx stylelint "src/css/**/*.scss"phpcsnpm run buildNote
_theme.scsshas no destructive token yet; adding one and converting every occurrence is tracked separately, so that this change does not leave a token and a literal in use for the same colour.