Repository navigation
Document API_URL for running the frontend without nginx - #6
Merged
Merged
Conversation
The frontend's /api proxy needs API_URL when nginx is not in front (npm run dev, Vercel). Add it to the README's environment table and local-dev steps, and as a commented entry in .env.example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents
API_URL, which the frontend's/api/*proxy (fixed in #5) needs whenever nginx is not in front of it. Docs only; no code changes.Changes
API_URLrow.frontend/.envlocally, project env vars on Vercel), that/api/*returns 503 without it, that Docker Compose doesn't need it, and that streamed responses on Vercel end at the function duration limit. Thenpm run devline now notes it needsAPI_URL..env.example: a commentedAPI_URL=http://localhost:8000entry, marked as a frontend variable that is not read from the root.env.Checked
Ran
npm run devwithAPI_URLinfrontend/.envagainst a local test backend; an/apicall was forwarded correctly.Not changed
frontend/.env.localis not git-ignored, which is why the docs point tofrontend/.env(ignored by the root.envrule).NEXT_PUBLIC_API_URL=/apiindocker-compose.ymlis not read by anything.