Repository navigation
fix: cover letters keep every paragraph - #22
Merged
Merged
Conversation
The renderer kept only the first four paragraphs, so when the model wrote five (it sometimes does, despite the prompt) the closing paragraph was silently dropped, as was any paragraph added in the letter editor. Every paragraph is now rendered; the letter's measured page fit (tighter spacing, then 10pt type) keeps it to one page, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The cover-letter renderer kept only the first four paragraphs (
_MAX_PARAGRAPHS = 4). When the model wrote five, which it sometimes does despite the prompt asking for exactly four, the closing paragraph was silently dropped. So was any paragraph added in the letter editor.Every paragraph is now rendered. The letter's measured page fit from #20 (tighter spacing, then 10pt type, never trimming) keeps it to one page, as before.
Testing