Skip to content

🤖 fix: separate General settings groups with thin dividers - #4079

Merged
ibetitsmike merged 2 commits into
mainfrom
mike/settings-section-dividers
Sep 4, 2026
Merged

🤖 fix: separate General settings groups with thin dividers#4079
ibetitsmike merged 2 commits into
mainfrom
mike/settings-section-dividers

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Settings > General groups its controls under headings (Appearance, Sidebar, Transcript, Terminal, Archiving, Editor & debugging, Projects), but only whitespace separated the groups, so the boundary between one group's last row and the next heading was hard to see. This adds a thin horizontal rule between the groups.

Implementation

Each group wrapper after the first gets border-border-light border-t pt-6: a 1px rule in the theme border color (the same token divide-border-light uses elsewhere in Settings), with the existing space-y-6 gap above the line and pt-6 below it so the heading is not glued to the rule. No rule above Appearance. Six className edits in GeneralSection.tsx, no new components or CSS.

Validation

  • Storybook GeneralSection story at 1100px and 390px: computed styles show 0px border on the Appearance wrapper and 1px rgb(38,38,38) + 24px padding-top on the other six; no horizontal overflow.
  • Remote dogfood UAT (Coder Agents) on this exact commit: six dividers with even spacing in dark and light themes at desktop and 390px, placement holds when the Terminal group grows/shrinks (Terminal Badge on/off), other tabs unchanged.
  • UAT also surfaced a pre-existing issue, not touched here: at 390px the Terminal Font input (fixed w-80) overflows the settings column; reproduced on the base commit.

Note: the first CI run inherited two failures from a then-red main (#3994's stale getSessionDir mock and five ProjectSidebar flat chat list renders missing archivingWorkspaceIds); #4077 fixed both on main, which is merged in here.


Generated with xum • Model: anthropic:claude-fable-5-1 • Thinking: xhigh • Cost: $19.46

@chatgpt-codex-connector

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

This comment has been minimized.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: e22c6623e1

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@ibetitsmike
ibetitsmike added this pull request to the merge queue Sep 4, 2026
Merged via the queue into main with commit 52822a8 Sep 4, 2026
19 of 20 checks passed
@ibetitsmike
ibetitsmike deleted the mike/settings-section-dividers branch September 4, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant