🤖 fix: separate General settings groups with thin dividers - #4079
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@codex review |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@codex review |
This comment has been minimized.
This comment has been minimized.
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings > General groups its controls under headings (Appearance, Sidebar, Transcript, Terminal, Archiving, Editor & debugging, Projects), but only whitespace separated the groups, so the boundary between one group's last row and the next heading was hard to see. This adds a thin horizontal rule between the groups.
Implementation
Each group wrapper after the first gets
border-border-light border-t pt-6: a 1px rule in the theme border color (the same tokendivide-border-lightuses elsewhere in Settings), with the existingspace-y-6gap above the line andpt-6below it so the heading is not glued to the rule. No rule above Appearance. Six className edits inGeneralSection.tsx, no new components or CSS.Validation
GeneralSectionstory at 1100px and 390px: computed styles show0pxborder on the Appearance wrapper and1px rgb(38,38,38)+24pxpadding-top on the other six; no horizontal overflow.w-80) overflows the settings column; reproduced on the base commit.Generated with
xum• Model:anthropic:claude-fable-5-1• Thinking:xhigh• Cost:$19.46