🤖 ci: ignore Codex informational cards in the Codex Comments gate - #4069
🤖 ci: ignore Codex informational cards in the Codex Comments gate#4069ibetitsmike wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
da19a99 to
dce5640
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dce56401a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Codex now posts a codex-pull-request-review-summary status comment when a PR opens. It is not a finding, but check_codex_comments.sh counted it as an unminimized bot comment and failed the Codex Comments check on every new PR.
An unanchored "No security issues were found" would also drop a comment that carries real findings alongside that phrase.
9f39370 to
d42cdcd
Compare
ibetitsmike
changed the title
9f39370 to
d42cdcd
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
1 participant
Summary
Codex now posts two informational comments that carry no findings: a
<!-- codex-pull-request-review-summary -->status card when a PR opens, and a "Security review completed. No security issues were found in this pull request." card after each review.scripts/check_codex_comments.sh(which theCodex CommentsCI job runs) counted both as unminimized bot comments, so the check failed on every freshly opened PR until someone minimized them by hand. This teaches the script to ignore exactly those two cards.Implementation
The exemptions are anchored to the exact card openings (
^<!-- codex-pull-request-review-summary -->and^Security review completed. No security issues were found in this pull request.) so a comment that carries real findings alongside similar prose is still counted.Validation
test()against the real card bodies from 🤖 perf: bind xum server listener before startup recovery; stop per-task config.json reloads #4058 and 🤖 ci: ignore Codex informational cards in the Codex Comments gate #4069 (both excluded) and an adversarial comment that mentions "No security issues were found" after a P1 finding (still counted)../scripts/check_codex_comments.sh 4069passes with the cards present and unminimized.History
This PR originally also carried the OpenAI 404
model_not_foundclassification fix; the identical fix landed on main via #4067, so the branch was reduced to the script change.Generated with
xum• Model:anthropic:claude-fable-5-1• Thinking:xhigh• Cost:$165.56