🤖 fix: archive all sidebar variants#3741
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 955b9b11a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed both findings:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f88e991a06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the portal keyboard finding by limiting row shortcuts to events targeting the group row itself, with coverage for Enter on the nested menu action. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1fe0e958a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the nested-menu archive shortcut finding: the shared archive keybind is handled and propagation is stopped before row-target filtering, while plain Enter/Space on menu controls remains isolated from row expansion. Added coverage for both paths. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Co-authored-by: Mux <noreply@coder.com>
Co-authored-by: Mux <noreply@coder.com>
Co-authored-by: Mux <noreply@coder.com>
Co-authored-by: Mux <noreply@coder.com>
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Both the archive keyboard-shortcut path and the context-menu item inlined
the byte-identical props.onArchiveAll(...).catch(() => { /* same comment */ })
fire-and-forget block (introduced by #3741). Extracted a local archiveAll
helper so the swallow-and-surface rationale lives in one place.
Both the archive keyboard-shortcut path and the context-menu item inlined
the byte-identical props.onArchiveAll(...).catch(() => { /* same comment */ })
fire-and-forget block (introduced by #3741). Extracted a local archiveAll
helper so the swallow-and-surface rationale lives in one place.
Both the archive keyboard-shortcut path and the context-menu item inlined
the byte-identical props.onArchiveAll(...).catch(() => { /* same comment */ })
fire-and-forget block (introduced by #3741). Extracted a local archiveAll
helper so the swallow-and-surface rationale lives in one place.
Both the archive keyboard-shortcut path and the context-menu item inlined
the byte-identical props.onArchiveAll(...).catch(() => { /* same comment */ })
fire-and-forget block (introduced by #3741). Extracted a local archiveAll
helper so the swallow-and-surface rationale lives in one place.
Both the archive keyboard-shortcut path and the context-menu item inlined
the byte-identical props.onArchiveAll(...).catch(() => { /* same comment */ })
fire-and-forget block (introduced by #3741). Extracted a local archiveAll
helper so the swallow-and-surface rationale lives in one place.
1 participant
Summary
Adds a context menu action to variant group rows in the sidebar so all variants can be archived together without expanding the group and archiving each chat individually.
Implementation
Risks
Low and limited to sidebar variant-group archive behavior. Individual workspace archive behavior continues to use the existing preflight, confirmation, and error handling paths.
Generated with
mux• Model:openai:gpt-5.6-sol• Thinking:medium• Cost:$13.98