Skip to content

chore(universal): disable PHP session upload progress - #344

Merged
cjfit merged 1 commit into
mainfrom
chore/universal-php-session-upload-progress
Oct 28, 2026
Merged

cjfit merged 1 commit into
mainfrom
chore/universal-php-session-upload-progress

Conversation

@cjfit

@cjfit cjfit commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Workspaces don't need PHP's session upload progress tracking, and the image currently inherits PHP's built-in default (enabled) for both PHP 8.5.12 and 8.4.27.

What

  • Adds a conf.d/session.ini drop-in to every installed PHP version under /usr/local/php that sets session.upload_progress.enabled=0.
  • Fails the build if any version still reports the setting as enabled, or if no PHP versions are found.
  • Kept as its own step so it survives removing the PHP rebuild step once the base image ships patched PHP.

Verification

  • dprint check passes.
  • CI's PR build exercises the new check.

🤖 Generated with Claude Code

Workspaces don't need PHP's session upload progress tracking. Turn it
off for every installed PHP version with a conf.d drop-in, and fail the
build if any version still reports it as enabled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cjfit
cjfit marked this pull request as ready for review October 28, 2026 15:35
@cjfit
cjfit merged commit 1413463 into main Oct 28, 2026
2 checks passed
@cjfit
cjfit deleted the chore/universal-php-session-upload-progress branch October 28, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants