Repository navigation
Add Vietnamese locale - #8107
Merged
Merged
Conversation
code-asher
approved these changes
Nov 3, 2026
Member
|
Thank you! |
code-asher
enabled auto-merge (squash)
November 3, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Vietnamese (
vi) translation of the login page strings.src/node/i18n/locales/vi.jsonwith all 11 keys fromen.json; the{{app}},$PASSWORDand$HASHED_PASSWORDplaceholders are kept unchanged.viindefaultResourcesinsrc/node/i18n/index.ts, following the Turkish locale (feat(i18n): add Turkish login locale #8050).No test was added. The per-language test that came with #8050 was later removed in #8069, so this PR follows the current state of
test/unit/node/i18n.test.ts.Checks run:
vi.jsonparses as JSON, its keys matchen.json(same order), placeholders match for every entry, andprettier --checkpasses on both changed files.