Make app-name configurable via environment variable.#7818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #7794 and continues fix to #7688.
I realized that CLI option is really inconvenient for my current setup, which is a general purpose code-server docker container that I can launch from any source code folder on my computer such that it is fully isolated via docker, but also retains my configuration settings. It has an entrypoint that sets the workspace, but the CLI doesn't let you pass additional arguments after the workspace so I can't just add
--app-name $APP_NAME.By making it an environment variable, I can simply provide the environment variable to docker run, and it will use that if
--app-nameisn't provided.