Repository navigation
Show only the newest toast on a phone - #60
Merged
Merged
Conversation
Below 48rem the stack runs the full width above the bottom bar, and three toasts took a third of the screen. The stylesheet now shows the newest one there; the older ones stay in the store and return when it goes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Below 48rem the toast stack runs the full width above the bottom bar, and three toasts in a row took about a third of a phone's height.
toast-stack.css: below 48rem,.lg-toasts > :not(:last-child)is hidden, so only the newest toast shows. The older ones stay in the store with their timers running and show again when the newest goes. From 48rem up nothing changes.toast-stack.browser.spec.ts: at 390px three toasts show one, the newest; at 1280px all three. The 390px case was red before the rule.Verified: all 22 browser test files (370 tests), the toast unit tests and
check:staticgreen.