Repository navigation
Suggestion warm-up after its code review (spec 028) - #57
Merged
Merged
Conversation
Closes ISC-535…ISC-543: the warm-up waits for the chat to be used and for a quiet window, retries a failed phrasing after a window, phrases each miss in its own language, keeps follow-ups out of the table, moves DataChanged out of the chat and runs on Boot's executor; the quiet window no longer waits behind a scheduled ingest pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 028 takes on the follow-ups deferred from spec 027's code review.
What changes
leadgen.chat.suggestion-quiet-window(default 30 s) has passed without a further change, so triaging applications one by one costs one call per pause (ISC-537).CompletableFuture.delayedExecutor, not by Boot'staskScheduler, whose single thread a pass holds for as long as it runs.leadgen.chat.suggestion-retry-after(default 5 min) instead of waiting for the data to move (ISC-535). At its bound the skip list drops expired entries first, then the oldest, and is never cleared whole.event.DataChangedreplaceschat.suggest.SuggestionDataChanged.analytics,applicationandarchiveimport nothing of the chat, andChatIsolationTestchecks imports and everychat_*table (ISC-541).applicationTaskExecutorand drops a trigger after shutdown quietly (ISC-540).No migration, and no value to set.
Verification
./gradlew build: 1304 backend cases, 96 unit and 22 browser test files, all green; the 13 skipped are the corpus tests without.emlsamples.SuggestionPrewarmTest, andPhrasingWithoutAContextTest(skip-list bound, follow-up cache, unbuildable-model log).assumeThat) when the runner leaves a gap of most of a window between two moves.