Skip to content

fix(email-blocks): keep the contact filter popovers on screen #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clbotdev merged 2 commits into from
Nov 12, 2026
Merged

fix(email-blocks): keep the contact filter popovers on screen #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eafaa3
fix(email-blocks): keep popovers within the viewport
s3rot0n1n Nov 12, 2026
bc0d212
fix(email-blocks): cap the filter builder's popovers, not the shadcn …
s3rot0n1n Nov 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/email-blocks-popover-height.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@sendlit/email-blocks": patch
---

The contact filter builder's segment and filter popovers now stay on screen. They are capped to the space left in the viewport and scroll, so a long list of filters no longer runs off the edge.
10 changes: 8 additions & 2 deletions packages/email-blocks/src/contact-filter-builder.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,10 @@ export function ContactFilterBuilder({
<span className="sr-only">{segmentTriggerSrLabel}</span>
</Button>
</PopoverTrigger>
<PopoverContent align="start" className="w-80 p-2">
<PopoverContent
align="start"
className="w-80 p-2 max-h-[var(--radix-popover-content-available-height)] overflow-y-auto"
>
<div className="px-2 py-2">
<p className="text-sm font-semibold">{segmentsHeading}</p>
<p className="mt-1 text-xs text-muted-foreground">
Expand Down Expand Up @@ -533,7 +536,10 @@ export function ContactFilterBuilder({
{filtersButtonLabel}
</Button>
</PopoverTrigger>
<PopoverContent align="start" className="w-80">
<PopoverContent
align="start"
className="w-80 max-h-[var(--radix-popover-content-available-height)] overflow-y-auto"
>
{!activeDefinition ? (
<div className="space-y-1">
<p
Expand Down
Loading