Repository navigation
Conversation
post_max_size values of 0 or -1 mean unlimited. The previous code returned the raw value, so the Content-Length check failed and the request body was never read. Treat non-positive values as PHP_INT_MAX.
carson-codeigniter4
Bot
added
the
bug
michalsn
approved these changes
Oct 22, 2026
Comment on lines
+41
to
+42
| - **HTTP:** Fixed a bug where ``IncomingRequest`` did not read the request body | ||
| when PHP's ``post_max_size`` was set to ``0`` or ``-1`` (unlimited). |
Member
|
Instead of a hand-rolled parser, we can use PHP's own |
paulbalandan
changed the title
post_max_size is unlimited
…dling in IncomingRequest
| * | ||
| * A value of 0 or less means unlimited. | ||
| */ | ||
| private function getPostMaxSize(?string $postMaxSize = null): int |
Member
There was a problem hiding this comment.
Why do you need the default here?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PHP treats
post_max_sizevalues of0or-1as unlimited, butIncomingRequestcomparedContent-Lengthagainst the raw value, so the request body was never read. Non-positive values are now treated asPHP_INT_MAX.Checklist: