fix: specify parameter names in Model @phpstan-method callable types - #10444
Open
gr8man wants to merge 1 commit into
Open
fix: specify parameter names in Model @phpstan-method callable types#10444gr8man wants to merge 1 commit into
gr8man wants to merge 1 commit into
Conversation
gr8man
force-pushed
the
fix/10443-model-phpstan-method-callable
branch
from
August 11, 2026 23:35
1fe8286 to
eca8178
Compare
paulbalandan
left a comment
Member
There was a problem hiding this comment.
This is still red on PHPStorm.
Member
|
And pls use the PR template moving forward. |
gr8man
force-pushed
the
fix/10443-model-phpstan-method-callable
branch
from
August 12, 2026 11:14
eca8178 to
0c3f1a2
Compare
…hpstan-method annotations
gr8man
force-pushed
the
fix/10443-model-phpstan-method-callable
branch
from
August 12, 2026 11:16
0c3f1a2 to
a5fd490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes PhpStorm docblock parsing errors (
Expected: variable) onModel@phpstan-methodannotations forwhen()andwhenNot()methods by:mixedtype hint to$conditionparameter (mixed $condition).$builderand$valuein thecallable(...)signature.(callable(...))|nullwith standard nullable type syntax?callable(...).Fixes #10443
Checklist: