test: add unit tests for GDHandler save and security exceptions#10414
Open
gr8man wants to merge 2 commits into
Open
test: add unit tests for GDHandler save and security exceptions#10414gr8man wants to merge 2 commits into
gr8man wants to merge 2 commits into
Conversation
| { | ||
| foreach (['gif', 'jpeg', 'png', 'webp'] as $type) { | ||
| if ($type === 'webp' && ! function_exists('imagecreatefromwebp')) { | ||
| continue; // Skip if not supported |
Comment on lines
+481
to
+482
| } catch (ImageException $e) { | ||
| $this->assertSame(lang('Images.saveFailed'), $e->getMessage()); |
Member
There was a problem hiding this comment.
Use a generic Throwable catch here. Then assert the exception type as ImageException.
| { | ||
| foreach (['gif', 'jpeg', 'png', 'webp'] as $type) { | ||
| if ($type === 'webp' && ! function_exists('imagecreatefromwebp')) { | ||
| continue; |
gr8man
force-pushed
the
test/gdhandler-save-coverage
branch
2 times, most recently
from
July 18, 2026 18:00
7856817 to
00cf519
Compare
michalsn
reviewed
Jul 19, 2026
Comment on lines
+510
to
+523
| public function testSaveUnsupportedImageType(): void | ||
| { | ||
| $this->handler->withFile($this->path); | ||
|
|
||
| // Force an invalid image type to ensure proper exception handling | ||
| $image = $this->handler->getFile(); | ||
| $image->imageType = 9999; | ||
|
|
||
| $this->expectException(ImageException::class); | ||
| $this->expectExceptionMessage(lang('Images.unsupportedImageCreate')); | ||
|
|
||
| // save() should throw an exception instead of fatal error in GD | ||
| $this->handler->save($this->start . 'work/ci-logo.jpg'); | ||
| } |
Member
There was a problem hiding this comment.
This tests an exception in getImageResource(), not in save().
Comment on lines
+492
to
+494
| if ($type === 'webp' && ! function_exists('imagecreatefromwebp')) { | ||
| $this->markTestSkipped('webp is not supported.'); | ||
| } |
Member
There was a problem hiding this comment.
For max quality, this should not be needed.
| $image->imageType = 9999; | ||
|
|
||
| $this->expectException(ImageException::class); | ||
| $this->expectExceptionMessage('Ima'); |
gr8man
force-pushed
the
test/gdhandler-save-coverage
branch
from
July 19, 2026 19:59
8a110e5 to
1f8ecac
Compare
gr8man
force-pushed
the
test/gdhandler-save-coverage
branch
from
July 19, 2026 20:01
1f8ecac to
1bc83dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing unit tests for
GDHandler::save()and unsupported image types exceptions to improve code coverage.Changes:
vfsStream.save($target, 100)unmodified copy logic.imageTypeto ensureImageExceptionis thrown instead of a fatal GD error.Checklist: