Revert usage of cmd on Windows - #109
Open
axel3rd wants to merge 1 commit into
Open
Conversation
axel3rd
marked this pull request as draft
December 21, 2020 11:30
axel3rd
force-pushed
the
update-41-Revert_usage_of_cmd_on_Windows
branch
from
December 21, 2020 11:32
965bed7 to
6168f2b
Compare
michael-o
requested changes
Dec 21, 2020
axel3rd
force-pushed
the
update-41-Revert_usage_of_cmd_on_Windows
branch
from
December 21, 2020 13:05
6168f2b to
5f9a5ec
Compare
axel3rd
marked this pull request as ready for review
December 21, 2020 13:25
Contributor
Author
|
Note: GitHub action verify problem with Java 16-ea is not part of this PR. |
Contributor
Author
|
(@michael-o: Requested changes have been done) |
Contributor
Author
See #116 |
Contributor
Author
|
Is this PR (or #110) not relevant 😢 ? |
michael-o
removed their request for review
October 23, 2022 08:59
slachiewicz
marked this pull request as draft
January 5, 2025 10:44
slachiewicz
added
need-rebase
axel3rd
force-pushed
the
update-41-Revert_usage_of_cmd_on_Windows
branch
2 times, most recently
from
August 16, 2026 21:36
5b90f41 to
5c05119
Compare
axel3rd
marked this pull request as ready for review
August 16, 2026 21:39
Contributor
Author
|
@slachiewicz Rebase this PR after closing #110 |
michael-o
reviewed
Aug 16, 2026
slachiewicz
removed
the
need-rebase
axel3rd
force-pushed
the
update-41-Revert_usage_of_cmd_on_Windows
branch
from
August 17, 2026 21:10
5c05119 to
436fb68
Compare
slachiewicz
approved these changes
Aug 18, 2026
There was a problem hiding this comment.
Pull request overview
This PR removes the implicit Windows cmd.exe wrapping behavior from Commandline execution/commandline generation, shifting responsibility for invoking built-ins (echo, dir, .cmd/.bat) to the caller. It also updates unit tests to reflect the new Windows behavior.
Changes:
- Deprecates
Commandline#getCommandline()and makes it return the raw (non-shell) command line on all OSes. - Updates
Commandline#execute()to execute the raw command line (no implicit Windows shell wrapping). - Adjusts
CommandlineTestcases that previously depended on Windows shell built-ins.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/org/codehaus/plexus/util/cli/Commandline.java | Removes Windows-specific shell wrapping from getCommandline() and aligns execution toward raw command arrays. |
| src/test/java/org/codehaus/plexus/util/cli/CommandlineTest.java | Updates tests to explicitly invoke cmd for Windows built-ins/scripts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+81
to
+84
| String binary = "mvn"; | ||
| if (Os.isFamily(Os.FAMILY_WINDOWS)) { | ||
| binary += ".cmd"; | ||
| } |
Comment on lines
+104
to
+110
| if (Os.isFamily(Os.FAMILY_WINDOWS)) { | ||
| cmd.createArg().setValue("Hello"); | ||
| executable = "cmd"; | ||
| cmd.createArg().setValue("/X"); | ||
| cmd.createArg().setValue("/C"); | ||
| cmd.createArg().setValue("echo"); | ||
| } |
Comment on lines
583
to
585
| if (workingDir == null) { | ||
| process = Runtime.getRuntime().exec(getCommandline(), environment, workingDir); | ||
| process = Runtime.getRuntime().exec(getRawCommandline(), environment, workingDir); | ||
| } else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an update of old previous staling PR #41
cf. #17 (comments from May 2018): Revert the usage of
cmd.exe(on Windows), because prevents the destroy/kill launched by this way whenCTRL+C.For history: This Windows shell specific is removed since plexus-utils 3.0.15, except for 3.1.0.
On Windows, the usage of cmd builtin (like
echo) or.cmd/.baton PATH should be implemented by the client/user.Another approach could be a dedicated option: See #110